From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19118 invoked by alias); 31 Jan 2013 16:12:47 -0000 Received: (qmail 19062 invoked by uid 22791); 31 Jan 2013 16:12:45 -0000 X-SWARE-Spam-Status: No, hits=-2.6 required=5.0 tests=AWL,BAYES_00,KHOP_SPAMHAUS_DROP,KHOP_THREADED,RCVD_IN_HOSTKARMA_YE X-Spam-Check-By: sourceware.org Received: from na3sys009aog110.obsmtp.com (HELO na3sys009aog110.obsmtp.com) (74.125.149.203) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 31 Jan 2013 16:12:38 +0000 Received: from mx10.qnx.com ([209.226.137.110]) (using TLSv1) by na3sys009aob110.postini.com ([74.125.148.12]) with SMTP ID DSNKUQqX8e2I6Hd3yqAJMbRJRJLuIEJ684nU@postini.com; Thu, 31 Jan 2013 08:12:37 PST Received: by mx10.qnx.com (Postfix, from userid 500) id 2037620E05; Thu, 31 Jan 2013 11:12:33 -0500 (EST) Received: from exhts.ott.qnx.com (exch2 [10.222.2.136]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by mx10.qnx.com (Postfix) with ESMTPS id DD287209AA; Thu, 31 Jan 2013 11:12:32 -0500 (EST) Received: from [10.222.96.215] (10.222.2.5) by EXCH2.ott.qnx.com (10.222.2.136) with Microsoft SMTP Server (TLS) id 14.2.318.4; Thu, 31 Jan 2013 11:12:32 -0500 Message-ID: <510A97F0.5050704@qnx.com> Date: Thu, 31 Jan 2013 16:12:00 -0000 From: Aleksandar Ristovski User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130106 Thunderbird/17.0.2 MIME-Version: 1.0 To: Tom Tromey CC: "gdb-patches@sourceware.org" Subject: Re: [patch] cleanup: Wunused - amd64 References: <5109E3D3.90207@qnx.com> <871ud19vvy.fsf@fleche.redhat.com> In-Reply-To: <871ud19vvy.fsf@fleche.redhat.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-01/txt/msg00753.txt.bz2 On 13-01-31 11:09 AM, Tom Tromey wrote: >>>>>> "Aleksandar" == Aleksandar Ristovski writes: > > Aleksandar> * amd64-tdep.c (fixup_riprel): Remove unused > Aleksandar> BYTE_ORDER, DISP. > > This one isn't obvious to me. > > Aleksandar> /* Compute the rip-relative address. */ > Aleksandar> - disp = extract_signed_integer (insn, sizeof (int32_t), byte_order); > > Is it really the case that this code does not need to use 'disp'? > Or is it a bug that it doesn't use it? It is not used. Is it a bug, I don't know, I haven't analyzed any deeper (but my patch would not make it any worse than what it is now). --- Aleksandar