From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6460 invoked by alias); 29 Jan 2013 16:26:44 -0000 Received: (qmail 6407 invoked by uid 22791); 29 Jan 2013 16:26:42 -0000 X-SWARE-Spam-Status: No, hits=-3.9 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 29 Jan 2013 16:26:36 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1U0E11-0004v7-9a from Vladimir_Prus@mentor.com ; Tue, 29 Jan 2013 08:26:31 -0800 Received: from SVR-IES-FEM-01.mgc.mentorg.com ([137.202.0.104]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Tue, 29 Jan 2013 08:26:30 -0800 Received: from [172.30.88.186] (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server id 14.1.289.1; Tue, 29 Jan 2013 16:26:28 +0000 Message-ID: <5107F832.6080405@codesourcery.com> Date: Tue, 29 Jan 2013 16:26:00 -0000 From: Vladimir Prus User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130106 Thunderbird/17.0.2 MIME-Version: 1.0 To: Marc Khouzam CC: 'Mircea Gherzan' , "'tromey@redhat.com'" , "'gdb-patches@sourceware.org'" Subject: Re: [RFC] Fix the MI result of -break-insert with multiple locations References: <1359470164-32004-1-git-send-email-mircea.gherzan@intel.com> <5107F02F.8070104@intel.com> In-Reply-To: Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-01/txt/msg00687.txt.bz2 On 29.01.2013 20:04, Marc Khouzam wrote: >> (gdb) >> -break-insert foobar >> ^done,bkpt={number="1",type="breakpoint",disp="keep",enabled=" >> y",addr="",times="0",original-location="foobar"},{nu > mber="1.1",enabled="y",addr="0x00000000004008d7",func="foobar()",file="overload.cpp",fullname=".../src/test-bktp-mi-> overload/overload.cpp",line="22",thread-groups=["i1"]},{number > ="1.2",enabled="y",addr="0x00000000004008e0",func="foobar(int)",file="overload.cpp",fullname=".../src/test-bktp-mi-> overload/overload.cpp",line="26",thread-groups=["i1"]} >> (gdb) >> >> So no square brackets. Therefore not a list and IMHO not a >> valid MI output. > > You're right. The output I took was from -break-list, but > for -break-insert, and probably some others, this does not > look to be valid syntax. > > I like your proposal of > bkpt={number="1", ... , locations=[{number="1.1", ...}, ...]} > > which would allow to easily differentiate between the "main bp > entry" and the "sub entries". I think it would help to see complete output, without ellipsis. (And when we agree that the proposed output is good, the patch would need testsuite changes to be accepted) Thanks, -- Vladimir Prus CodeSourcery / Mentor Graphics http://www.mentor.com/embedded-software/