From: Pedro Alves <palves@redhat.com>
To: Yao Qi <yao@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 2/2] Don't query stub if the pid is faked
Date: Thu, 24 Jan 2013 17:23:00 -0000 [thread overview]
Message-ID: <51016DF7.6010506@redhat.com> (raw)
In-Reply-To: <1358930116-29038-2-git-send-email-yao@codesourcery.com>
On 01/23/2013 08:35 AM, Yao Qi wrote:
> This patch fixes this problem by skipping query to the stub is the pid is faked.
Sorry, that's not correct.
`qAttached:pid'
Return an indication of whether the remote server attached to an existing
process or created a new process. When the multiprocess protocol extensions are
supported (...), pid is an integer in hexadecimal format identifying the
target process. Otherwise, gdb will omit the pid field and the query
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
packet will be simplified as `qAttached'.
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
And in that case, the pid will be faked.
If the target supports the multiprocess extensions, then the T stop
reply will include the "thread:ptid" bit, so my alternative patch
to 1/2 also fixes this. We could perhaps add some warning, but
I'm thinking it's not worth the bother.
--
Pedro Alves
--
Pedro Alves
next prev parent reply other threads:[~2013-01-24 17:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-23 8:36 [PATCH 1/2] Fix error when GDB connects to GDBserver with qC disabled Yao Qi
2013-01-23 8:36 ` [PATCH 2/2] Don't query stub if the pid is faked Yao Qi
2013-01-24 17:23 ` Pedro Alves [this message]
2013-01-24 17:05 ` [PATCH 1/2] Fix error when GDB connects to GDBserver with qC disabled Pedro Alves
2013-01-25 10:44 ` Yao Qi
2013-01-25 17:30 ` Pedro Alves
2013-01-25 17:41 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51016DF7.6010506@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox