From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15764 invoked by alias); 27 Oct 2017 12:49:50 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 15751 invoked by uid 89); 27 Oct 2017 12:49:50 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=realize X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 27 Oct 2017 12:49:48 +0000 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 756EB4A6EB for ; Fri, 27 Oct 2017 12:49:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 756EB4A6EB Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=palves@redhat.com Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9E86A60BEB; Fri, 27 Oct 2017 12:49:46 +0000 (UTC) Subject: Re: [PATCH 1/2] Report call site for inlined functions To: Keith Seitz , gdb-patches@sourceware.org References: <1499740601-15957-1-git-send-email-keiths@redhat.com> From: Pedro Alves Message-ID: <50be1b3b-00d1-6753-3245-ad17327176c2@redhat.com> Date: Fri, 27 Oct 2017 12:49:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-10/txt/msg00850.txt.bz2 On 10/20/2017 07:46 PM, Keith Seitz wrote: > [My reply seems not to have made it to sourceware, so I'm resending.] > > On 07/18/2017 12:05 PM, Pedro Alves wrote: >> On 07/11/2017 03:36 AM, Keith Seitz wrote: >>> >>> Here you can see the new call-site-func, call-site-file, call-site-fullname, >>> and call-site-line. >> >> The non-inlined call site seems sufficient info to me, at least for >> the CLI. I'm not sure whether "call-site" is sufficiently clear that >> it's referring to that vs the immediate potential inlined-too >> caller though. I think at least the docs need such a clarification. > > There seems to be consensus on the (lack of) utility of this call-site info, so in the next revision (to follow), I've chosen to remove it all. I think that pretty much resolves (by deletion!) most of your concerns/comments. I've also removed the inlined_symbol proposal since that is also no longer necessary. I think my observations in still make sense, and I don't know about consensus, but OK, let's move on. I'll take a look at the new version. > >>> diff --git a/gdb/dwarf2read.c b/gdb/dwarf2read.c >>> index 0fdcd42..3b3193b 100644 >>> --- a/gdb/dwarf2read.c >>> +++ b/gdb/dwarf2read.c >>> @@ -11540,13 +11571,28 @@ read_func_scope (struct die_info *die, struct dwarf2_cu *cu) >>> { >>> templ_func = allocate_template_symbol (objfile); >>> templ_func->base.is_cplus_template_function = 1; >>> + symbol_storage = (struct symbol *) templ_func; >>> break; >>> } >>> } >>> >>> + /* If we have an inlined symbol, we must also allocate a different >>> + symbol. */ >> >> How does this work when you have an (inlined) template function? >> Like e.g.,: >> >> template >> static T inline_func (T val) >> { >> return val * 2; >> } >> >> int >> not_inline_func (int val) >> { >> return inline_func (val * 2); >> } >> > > I realize this was asked in relation to the proposed (and now deleted) inline_symbol, but to be clear, the above example works: > > (gdb) b inline_func > Breakpoint 1 at 0x4004c0: file inline-t.cc, line 9. > (gdb) i b > Num Type Disp Enb Address What > 1 breakpoint keep y 0x00000000004004c0 in inline_func > at inline-t.cc:9 OK, it seems like a DIE can't be both DW_TAG_inlined_subroutine and a template (kind of makes sense), so you couldn't ever end up calling both allocate_template_symbol and allocate_inlined_symbol for the same symbol (which is what I was worrying about, because the code didn't consider/guard against that). Thanks, Pedro Alves