From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id sbgXIMoD62X/9D0AWB0awg (envelope-from ) for ; Fri, 08 Mar 2024 07:25:46 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=kIQMT+XA; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=keWGRqVL; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=kIQMT+XA; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=keWGRqVL; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 70DFC1E0D2; Fri, 8 Mar 2024 07:25:46 -0500 (EST) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id A5D741E092 for ; Fri, 8 Mar 2024 07:25:43 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 156333858415 for ; Fri, 8 Mar 2024 12:25:43 +0000 (GMT) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by sourceware.org (Postfix) with ESMTPS id 62B543858D33 for ; Fri, 8 Mar 2024 12:25:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 62B543858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 62B543858D33 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709900728; cv=none; b=FYHl4197ZJJoYLnVYtjwOpyDKhvjsRvfBhiA+pIjGc9RPZU7l6OPELUh9xqyMbw4Vr/lsd1pa52q1qWimqayUtOGHyy0N9Yvc8m5eQCN/J3BqUJJudSyAJyRxvLshis7tVIM3juLUHIZky7hB0nsAseeV313UO3yKfqmtP6GyTY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709900728; c=relaxed/simple; bh=SZe6keIXbZ6DoQVsEoxn10uM//4B8GVG0YXlVog85NU=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:From:To; b=OThn2P9t6M4r/QPwQj3lHSSusXiOmSUS/9sfbk4TYptQhH9+Q3AlufVjzci3+wJKpEIRgWLTqdh1X4NC/ruUohtWVergvrJ3vYC+PhJD92XlGaUe7D0UyA8o/hEZyD8CpZxiUOgZnA9BMcPXqdF2k5bta7Npeon7P/VwATaDcKQ= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 07F7F37159; Fri, 8 Mar 2024 10:11:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1709892712; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WoZFiximJv0rmYRpDcsTlthKBADTlAQ0SigtZJK3vnk=; b=kIQMT+XAKy3Paj4tqgkhUEL3xSpTwzJ5cDD01XiBgxkhD6hBmBU7kMcETdGZDufz0r0/GS iRC9yzcHF6l3i2WpZmb/i7S7IVLsaP/7obo3lz5aJMP8YCBklnGyj99V4d1qscFguP3YbV mAEg/R4Ptvdfs6I9Fi5mtMmKjtURE8k= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1709892712; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WoZFiximJv0rmYRpDcsTlthKBADTlAQ0SigtZJK3vnk=; b=keWGRqVLM7pzojuVaHuo6nOPUZyCm9bOpvhTpo6cXXWP8LGIbRPB/JbFcgoFv3pSm6sDXD H8aff6ZCfu2JVqBw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1709892712; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WoZFiximJv0rmYRpDcsTlthKBADTlAQ0SigtZJK3vnk=; b=kIQMT+XAKy3Paj4tqgkhUEL3xSpTwzJ5cDD01XiBgxkhD6hBmBU7kMcETdGZDufz0r0/GS iRC9yzcHF6l3i2WpZmb/i7S7IVLsaP/7obo3lz5aJMP8YCBklnGyj99V4d1qscFguP3YbV mAEg/R4Ptvdfs6I9Fi5mtMmKjtURE8k= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1709892712; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WoZFiximJv0rmYRpDcsTlthKBADTlAQ0SigtZJK3vnk=; b=keWGRqVLM7pzojuVaHuo6nOPUZyCm9bOpvhTpo6cXXWP8LGIbRPB/JbFcgoFv3pSm6sDXD H8aff6ZCfu2JVqBw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id E4C6E13310; Fri, 8 Mar 2024 10:11:51 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id qn2uNWfk6mWPagAAD6G6ig (envelope-from ); Fri, 08 Mar 2024 10:11:51 +0000 Message-ID: <50aad175-7599-434c-8dad-d50b7ad9cec8@suse.de> Date: Fri, 8 Mar 2024 11:12:29 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/2] gdb/testsuite: fix gdb.threads/threadcrash.exp on 32-bit arm targets Content-Language: en-US From: Tom de Vries To: Guinevere Larsen , gdb-patches@sourceware.org References: <20240214091712.223928-2-blarsen@redhat.com> <20240214091712.223928-3-blarsen@redhat.com> <30e8c69c-e5ef-4fd5-8328-85413b21de4c@suse.de> In-Reply-To: <30e8c69c-e5ef-4fd5-8328-85413b21de4c@suse.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Level: Authentication-Results: smtp-out1.suse.de; none X-Spamd-Result: default: False [-0.68 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; XM_UA_NO_VERSION(0.01)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; BAYES_HAM(-0.59)[81.54%]; MIME_GOOD(-0.10)[text/plain]; RCVD_COUNT_THREE(0.00)[3]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; RCPT_COUNT_TWO(0.00)[2]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[] X-Spam-Score: -0.68 X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org On 3/8/24 11:01, Tom de Vries wrote: > On 2/14/24 10:17, Guinevere Larsen wrote: >> -test_gcore >> +if { [is_aarch32_target] } { >> +    kfail "gcore tests fail on 32-bit arm, see PR corefiles/31294" >> +} else { >> +    test_gcore >> +} > > The xfail and kfail procs don't have the same args: > ... > $ egrep -d skip "proc (xfail|kfail)" /usr/share/dejagnu/* > /usr/share/dejagnu/framework.exp:proc xfail { message } { > /usr/share/dejagnu/framework.exp:proc kfail { bugid message } { > ... > and consequently this patch runs into an error. > And ... I just realized I made the same mistake in v4. I already spotted another mistake, I intended to bail out after the kfail and forgot to add that. I'll follow up on the patch once it arrives on the ml. Thanks, - Tom > Furthermore, I don't run into the reported problem on my setup (pinebook > aarch64 manjaro, chroot debian 32-bit), so this style of kfail actually > prevents me from successfully running the tests. > > I proposed a more precise fix in v4, though I can't test it ... > > Thanks, > - Tom