Re: [RFA 3/5] New port: CR16: gdb port

Joel Brobecker
2012-10-23T13:55:09Z

> These globals are actually declared in /opcodes/cr16-dis.c and my
> earlier version of this patch had declared them extern here.
> Converting the disassembler piece of code would be bit tricky as
> print_insn_cr16 and print_arg seem to use these globals directly.
> Would it be OK just to leave them as extern here with appropriate
> comments?

Can you declare those externs somewhere in opcode instead? That way,
both opcode and GDB would use the same declaration, and that would
ensure consistency.

> I will make that change for unwind_pc and unwind_sp as well. The locals helped
> me debug my code better, but I can remove them now.

You do not have to, if you prefer it the other way. But I would make
sure that the type of the variables match the return type.

> I think I can remove this fixme as the issue is actually at the sim end.
> The host side gdb gets correct information about data types directly from
> the symbol table. The simulator totally gets lost when -mint32 is passed.

Cool :).

--
Joel