From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2575 invoked by alias); 23 Jan 2013 14:26:00 -0000 Received: (qmail 2558 invoked by uid 22791); 23 Jan 2013 14:25:56 -0000 X-SWARE-Spam-Status: No, hits=-7.7 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 23 Jan 2013 14:25:46 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r0NEPhY2006661 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 23 Jan 2013 09:25:43 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r0NEPeg4025232; Wed, 23 Jan 2013 09:25:41 -0500 Message-ID: <50FFF2E4.6000906@redhat.com> Date: Wed, 23 Jan 2013 14:26:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: Kaushik Phatak CC: Joel Brobecker , "gdb-patches@sourceware.org" , Yao Qi , Tom Tromey Subject: Re: [RFA 3/5] New port: CR16: gdb port References: <20121022224107.GB3713@adacore.com> <20121023135502.GA3555@adacore.com> <20121115174313.GC3790@adacore.com> <20121122175010.GG9964@adacore.com> <20130117085919.GA3564@adacore.com> <20130118141649.GK3564@adacore.com> <50FEABC8.2040805@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-01/txt/msg00551.txt.bz2 On 01/23/2013 02:22 PM, Kaushik Phatak wrote: >> > How about exporting a function that hides these opcodes details? >> > I don't even pretend to understand what the code is trying to do, >> > and it'd be an opportunity to comment it in the function description. >> > /* Take BUF, do something with it, and write length >> > to LENGTH. Blah, blah. */ >> > cr16_do_something (buf, *length, ...); > I think this can be done and it will make this code look cleaner. > An exported function in bfd would make my code look like this, > ... > target_read_memory (pc, buf, 6); > cr16_get_insn_length (buf, *length, ...); > next_pc = pc + length; > ... > If it's the instruction length you need, then did you try gdb_buffered_insn_length or gdb_insn_length? -- Pedro Alves