From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31572 invoked by alias); 19 Jan 2013 13:46:06 -0000 Received: (qmail 31478 invoked by uid 22791); 19 Jan 2013 13:46:02 -0000 X-SWARE-Spam-Status: No, hits=-2.8 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.fgznet.ch (HELO smtp.fgznet.ch) (81.92.96.47) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 19 Jan 2013 13:45:54 +0000 Received: from deuterium.andreas.nets (dhclient-91-190-14-19.flashcable.ch [91.190.14.19]) by smtp.fgznet.ch (8.13.8/8.13.8/Submit_SMTPAUTH) with ESMTP id r0JDjpEG079564 for ; Sat, 19 Jan 2013 14:45:52 +0100 (CET) (envelope-from andreast-list@fgznet.ch) Message-ID: <50FAA38F.3050100@fgznet.ch> Date: Sat, 19 Jan 2013 13:46:00 -0000 From: Andreas Tobler User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:17.0) Gecko/20130107 Thunderbird/17.0.2 MIME-Version: 1.0 To: gdb-patches@sourceware.org Subject: Re: [RFC] patch to refactor ppc64 specific code from ppc-linux-tdep References: <50DCBF4B.7000009@fgznet.ch> In-Reply-To: <50DCBF4B.7000009@fgznet.ch> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-01/txt/msg00462.txt.bz2 Ping? Thanks, Andreas On 27.12.12 22:36, Andreas Tobler wrote: > Hi all, > > in order to avoid code duplication for the FreeBSD powerpc port I > started to cut off common code from ppc-linux-tdep.c into a new file to > be used for FreeBSD and GNU/Linux PowerPC 64-bit. The file name is open > so far. Better namings are welcome. > > Attached my first attempt, tested on GNU/Linux ppc64, Fedora 17 and on > x86_64-*freebsd* with --eanble-targets=all. On the Linux side I do not > see any regression. > So far I have only covered functions which I can use on FreeBSD > powerpc64. There might be others too but I do not see any for now. > > I'd appreciate comments, corrections. > > TIA, > Andreas > > 2012-12-19 Andreas Tobler > > * Makefile.in (ALL_TARGET_OBS): Add new file ppc64-common-tdep.o > (HFILES_NO_SRCDIR): Likewise. > (ALLDEPFILES): Likewise. > * configure.tgt: Add new file for powerpc-linux. > * ppc64-common-tdep.h: New file. > * ppc64-common-tdep.c New file. > (insn_d, insn_ds, insn_xfx, read_insn) > (insns_match_pattern, insn_d_field, insn_ds_field) > (ppc64_desc_entry_point): Move from ppc-linux-tdep.c to here. > (PPC64_STANDARD_LINKAGE1_LEN, PPC64_STANDARD_LINKAGE2_LEN) > (PPC64_STANDARD_LINKAGE2_LEN): Likewise and use ARRAY_SIZE macro. > (ppc64_standard_linkage1_target, ppc64_standard_linkage2_target) > (ppc64_standard_linkage3_target, ppc64_skip_trampoline_code): Move > from ppc-linux-tdep.c to here. > (ppc64_convert_from_func_ptr_addr): Rename it from > ppc64_linux_convert_from_func_ptr_addr to > ppc64_convert_from_func_ptr_addr and move it from ppc-linux-tdep.c to > here. > * ppc-linux-tdep.c: Include ppc64-common-tdep.h. > Removed above functions. > (ppc_linux_init_abi): Rename > ppc64_linux_convert_from_func_ptr_addr to > ppc64_linux_convert_from_func_ptr_addr. > >