Re: [PATCH] Rename psymtab_to_symtab to read_symtab

Tom Tromey
2013-01-16T16:31:50Z

>>>>> "Yao" == Yao Qi <yao@codesourcery.com> writes:

Yao> During review the patch, we find it is more clear to either rename
Yao> FOO_psymtab_to_symtab to FOO_read_symtab or rename field 'read_symtab'
Yao> in 'struct partial_symtab' to 'psymtab_to_symtab'. See the discussion
Yao> here <http://sourceware.org/ml/gdb-patches/2013-01/msg00238.html>

Thanks for doing this.

Yao> - dbx_psymtab_to_symtab_1 (objfile, pst);
Yao> + dbx_psymtab_to_symtab_1 (objfile, self);

It seems slightly odd to rename the containing functions and reorder
their arguments, but not apply the same treatment to the worker
functions.

However, I don't mind. This patch is ok.

If you want to fix up the _1 functions as well, that is ok too.

Tom