From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14272 invoked by alias); 18 Jan 2013 03:16:26 -0000 Received: (qmail 14261 invoked by uid 22791); 18 Jan 2013 03:16:25 -0000 X-SWARE-Spam-Status: No, hits=-4.0 required=5.0 tests=AWL,BAYES_00,FROM_12LTRDOM,KHOP_RCVD_UNTRUST,KHOP_THREADED,MISSING_HEADERS,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 18 Jan 2013 03:16:18 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1Tw2RG-000527-2T from Yao_Qi@mentor.com for gdb-patches@sourceware.org; Thu, 17 Jan 2013 19:16:18 -0800 Received: from SVR-ORW-FEM-02.mgc.mentorg.com ([147.34.96.206]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Thu, 17 Jan 2013 19:16:17 -0800 Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-02.mgc.mentorg.com (147.34.96.168) with Microsoft SMTP Server id 14.1.289.1; Thu, 17 Jan 2013 19:16:16 -0800 Message-ID: <50F8BE5A.3040907@codesourcery.com> Date: Fri, 18 Jan 2013 03:16:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 CC: Subject: committed: [PATCH] Rename psymtab_to_symtab to read_symtab References: <1358350197-24304-1-git-send-email-yao@codesourcery.com> <87sj61gkep.fsf@fleche.redhat.com> In-Reply-To: <87sj61gkep.fsf@fleche.redhat.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-01/txt/msg00401.txt.bz2 On 01/17/2013 12:30 AM, Tom Tromey wrote: > Thanks for doing this. > > Yao> - dbx_psymtab_to_symtab_1 (objfile, pst); > Yao> + dbx_psymtab_to_symtab_1 (objfile, self); > > It seems slightly odd to rename the containing functions and reorder > their arguments, but not apply the same treatment to the worker > functions. > > However, I don't mind. This patch is ok. Patch is committed. -- Yao (齐尧)