From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22634 invoked by alias); 11 Jan 2013 14:56:08 -0000 Received: (qmail 22574 invoked by uid 22791); 11 Jan 2013 14:56:07 -0000 X-SWARE-Spam-Status: No, hits=-4.6 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 11 Jan 2013 14:56:00 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1Ttg1W-0007Ha-8f from Yao_Qi@mentor.com ; Fri, 11 Jan 2013 06:55:58 -0800 Received: from SVR-ORW-FEM-05.mgc.mentorg.com ([147.34.97.43]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Fri, 11 Jan 2013 06:55:58 -0800 Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-05.mgc.mentorg.com (147.34.97.43) with Microsoft SMTP Server id 14.1.289.1; Fri, 11 Jan 2013 06:55:57 -0800 Message-ID: <50F027E4.5010702@codesourcery.com> Date: Fri, 11 Jan 2013 14:56:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: Tom Tromey CC: Joel Brobecker , Subject: Re: [PATCH] Don't check PST is NULL in read_symtab References: <1357869440-23451-1-git-send-email-yao@codesourcery.com> <20130111045233.GK6143@adacore.com> <87libzu6tn.fsf@fleche.redhat.com> In-Reply-To: <87libzu6tn.fsf@fleche.redhat.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-01/txt/msg00222.txt.bz2 On 01/11/2013 10:34 PM, Tom Tromey wrote: > Joel> If PST must not be NULL, I think that it should be documented in > Joel> psympriv.h. I am also wondering whether an assertion would be > Joel> useful or not; maybe not, just thinking out loud. > > Joel> Tom and Doug are more involved in this area, so they'll probably > Joel> have a more definitive answer. > > An assert would be fine by me. An assert that PST is not NULL at the beginning of these functions dbx_psymtab_to_symtab_1, dwarf2_psymtab_to_symtab, mdebug_psymtab_to_symtab, and xcoff_psymtab_to_symtab_1? -- Yao (齐尧)