Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [commit] LynxOS: Resume the same thread when receiving a thread create/exit event.
Date: Fri, 04 Jan 2013 20:59:00 -0000	[thread overview]
Message-ID: <50E742A1.6040804@redhat.com> (raw)
In-Reply-To: <1355743597-15380-1-git-send-email-brobecker@adacore.com>

On 12/17/2012 11:26 AM, Joel Brobecker wrote:
> Before this patch, the ptid passed to lynx_resume was completely
> ignored, and we used the current_inferior. This resulted in trying
> to resume the inferior execution using the wrong ptid after having
> received a thread create/exit event, because the inferior_ptid
> was still set to the ptid prior to receiving the signal.
> 
> gdb/gdbserver/ChangeLog:
> 
>         * lynx-low.c (lynx_resume): Use the resume_info parameter
>         to determine the ptid for the lynx_ptrace call, unless
>         it is equal to minus_one_ptid, in which case we use the
>         ptid of the current_inferior.
>         (lynx_wait_1): After having received a thread create/exit
>         event, resume the inferior's execution using the signaling
>         thread's ptid, rather than the old ptid.
> 
> Tested on ppc-lynx5.
> 
> I hesitated a little before self-approving.  But it seemed sufficiently
> straightforward and enough of an improvement (in lynx_resume) that
> I allowed myself to go ahead. I will handle comments right away,
> if any.

Looks fine to me.

-- 
Pedro Alves


  parent reply	other threads:[~2013-01-04 20:59 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-17 11:26 Joel Brobecker
2012-12-17 11:33 ` Joel Brobecker
2013-01-04 20:59 ` Pedro Alves [this message]
2013-01-07 11:52   ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50E742A1.6040804@redhat.com \
    --to=palves@redhat.com \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox