Re: [patch] make older gcc happy mips-tdep.c

Andreas Tobler
2012-12-19T20:09:44Z

Hi Tom!

On 19.12.12 20:15, Tom Tromey wrote:
>>>>>> "Andreas" == Andreas Tobler <andreast-list@fgznet.ch> writes:
>
> Andreas> 2012-12-19 Andreas Tobler <andreast@neon.andreas.nets>
>
> Andreas> * mips-tdep.c (mips_deal_with_atomic_sequence): Initialize
> Andreas> branch_bp to keep gcc happy.
>
> This is ok, but I'm pretty surprised that the problem is here and not in
> micromips_deal_with_atomic_sequence. The latter looks more like the
> kind of usage that would provoke warnings from gcc.

Your surprise is correct! I did something wrong. I have wrongly applied
the patch from my git repo to the cvs repo. A rebuild with the cvs repo
showed that you are absolutely correct.

Thank you very much.

I'll commit the below if ok.

Andreas

2012-12-19 Andreas Tobler <andreast@neon.andreas.nets>

* mips-tdep.c (micromips_deal_with_atomic_sequence): Initialize
branch_bp to keep gcc happy.

Index: mips-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/mips-tdep.c,v
retrieving revision 1.564
diff -u -r1.564 mips-tdep.c
--- mips-tdep.c 12 Nov 2012 21:59:07 -0000 1.564
+++ mips-tdep.c 19 Dec 2012 20:05:21 -0000
@@ -3796,7 +3796,8 @@
const int atomic_sequence_length = 16; /* Instruction sequence
length. */
int last_breakpoint = 0; /* Defaults to 0 (no breakpoints placed). */
CORE_ADDR breaks[2] = {-1, -1};
- CORE_ADDR branch_bp; /* Breakpoint at branch instruction's
destination. */
+ CORE_ADDR branch_bp = 0; /* Breakpoint at branch instruction's
+ destination. */
CORE_ADDR loc = pc;
int sc_found = 0;
ULONGEST insn;