From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24171 invoked by alias); 18 Dec 2012 08:54:54 -0000 Received: (qmail 24160 invoked by uid 22791); 18 Dec 2012 08:54:53 -0000 X-SWARE-Spam-Status: No, hits=-4.6 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 18 Dec 2012 08:54:22 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1TkswP-00014Q-Lt from Yao_Qi@mentor.com ; Tue, 18 Dec 2012 00:54:21 -0800 Received: from SVR-ORW-FEM-04.mgc.mentorg.com ([147.34.97.41]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Tue, 18 Dec 2012 00:54:20 -0800 Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-04.mgc.mentorg.com (147.34.97.41) with Microsoft SMTP Server id 14.1.289.1; Tue, 18 Dec 2012 00:54:20 -0800 Message-ID: <50D02F1C.6020308@codesourcery.com> Date: Tue, 18 Dec 2012 08:54:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:15.0) Gecko/20120911 Thunderbird/15.0.1 MIME-Version: 1.0 To: Pierre Muller CC: Subject: Re: [RFA/OBVIOUS?] ui_file_new function missing "extern" in header. References: <001801cddcfa$a93cef10$fbb6cd30$@muller@ics-cnrs.unistra.fr> In-Reply-To: <001801cddcfa$a93cef10$fbb6cd30$@muller@ics-cnrs.unistra.fr> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-12/txt/msg00623.txt.bz2 On 12/18/2012 04:35 PM, Pierre Muller wrote: > i.e. shouldn't all functions declared in headers > have the extern modifier? > Is this mandatory? Better to do that... > It doesn't see to change anything in practice, but to me, > it seems like good practice... > ... but remember that my C programming knowledge is weak... Tom fixed a bug (gdbserver PR 14917) recently, which is about adding 'extern' in header. http://sourceware.org/ml/gdb-patches/2012-12/msg00072.html -- Yao (齐尧)