From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23591 invoked by alias); 17 Dec 2012 16:13:43 -0000 Received: (qmail 23581 invoked by uid 22791); 17 Dec 2012 16:13:41 -0000 X-SWARE-Spam-Status: No, hits=-3.2 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mms2.broadcom.com (HELO mms2.broadcom.com) (216.31.210.18) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 17 Dec 2012 16:13:37 +0000 Received: from [10.9.200.133] by mms2.broadcom.com with ESMTP (Broadcom SMTP Relay (Email Firewall v6.5)); Mon, 17 Dec 2012 08:10:33 -0800 X-Server-Uuid: 4500596E-606A-40F9-852D-14843D8201B2 Received: from mail-irva-13.broadcom.com (10.11.16.103) by IRVEXCHHUB02.corp.ad.broadcom.com (10.9.200.133) with Microsoft SMTP Server id 8.2.247.2; Mon, 17 Dec 2012 08:12:10 -0800 Received: from [10.177.72.90] (unknown [10.177.72.90]) by mail-irva-13.broadcom.com (Postfix) with ESMTP id 3F5DF40FE4 for ; Mon, 17 Dec 2012 08:12:24 -0800 (PST) Message-ID: <50CF4467.5090603@broadcom.com> Date: Mon, 17 Dec 2012 16:13:00 -0000 From: "Andrew Burgess" User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: gdb-patches@sourceware.org Subject: Re: [rfc] Print MI fullname even for non-existing files References: <20121217155859.GA8029@host2.jankratochvil.net> In-Reply-To: <20121217155859.GA8029@host2.jankratochvil.net> Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-12/txt/msg00571.txt.bz2 On 17/12/2012 3:58 PM, Jan Kratochvil wrote: > Currently this patch only changes from user point of view MI: > (gdb) -file-list-exec-source-file > ^done,line="1",file="deleted.c",macro-info="0" > -> > ^done,line="1",file="deleted.c",fullname="/path/to/deleted.c",macro-info="0" Seems like a good change to me. > Is there a serious reason why fullname was suppressed for non-existing files? I added the fullname field in source.c, there was no good reason then for dropping the field if we got NULL back except that (1) it matched the behaviour in stack.c, and (2) if we got null back then I'd have just left the field empty which didn't feel very useful. > While it breaks MI compatibility in some way I find it an acceptable change. I agree. Thanks, Andrew