From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29995 invoked by alias); 14 Dec 2012 17:17:53 -0000 Received: (qmail 29983 invoked by uid 22791); 14 Dec 2012 17:17:51 -0000 X-SWARE-Spam-Status: No, hits=-7.6 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 14 Dec 2012 17:17:44 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qBEHHfBi031562 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 14 Dec 2012 12:17:41 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id qBEHHdPl014152; Fri, 14 Dec 2012 12:17:40 -0500 Message-ID: <50CB5F33.2030402@redhat.com> Date: Fri, 14 Dec 2012 17:17:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: Joel Brobecker CC: gdb-patches@sourceware.org Subject: Re: [RFA 2/3] gdbarch-ification of ravenscar-thread support. References: <1355497356-13922-1-git-send-email-brobecker@adacore.com> <1355497356-13922-2-git-send-email-brobecker@adacore.com> In-Reply-To: <1355497356-13922-2-git-send-email-brobecker@adacore.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-12/txt/msg00511.txt.bz2 On 12/14/2012 03:02 PM, Joel Brobecker wrote: > Hello, > > This one is the biggie, moving ravenscar-thread to the gdbarch age. > > The changes in the ravenscar modules themselves are quite > straightforward, but the changes to Makefile.in (adding the > right files to the right lists), and configure.tgt (adding > ravenscar-sparc-thread.o everywhere sparc-tdep.o is listed) > where slightly trickier. Also, I have a question, hence the > RFA. > > The question: Right now, I put ravenscar-thread.o in the list of > objects to always be built, regardless of whether or not GDB is > configured with a target that can take advantage of it. I seems > slightly wasteful, but somehow consistent with have solib-target > always available, for instance. It's a little bit different, because solib-target is driven entirely from data the target pushes to GDB. Any random embedded target can enable that with no changes to GDB. Ravenscar support always needs code changes in GDB, OTOH. > It's really easy to change: we > just have to remove ravenscar-thread.o from Makefile.in, and > add it to the gdb_target_obs instead. WDYT? Don't see why not. You already have to add ravenscar-ARCH-thread.c there anyway. But I'm not going to object. BTW, ARCH-ravenscar-thread.c would be a naming scheme more in line with other files. Can we change that before adding more ports? > > gdb/ChangeLog: > > * gdbarch.sh: Add "struct ravenscar_arch_ops" advance > declaration. s/advance/forward/ Otherwise looks fine to me. -- Pedro Alves