From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6777 invoked by alias); 13 Dec 2012 20:27:15 -0000 Received: (qmail 6732 invoked by uid 22791); 13 Dec 2012 20:27:13 -0000 X-SWARE-Spam-Status: No, hits=-7.6 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 13 Dec 2012 20:27:06 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qBDKQttM001446 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 13 Dec 2012 15:26:55 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id qBDKQrUY009951; Thu, 13 Dec 2012 15:26:54 -0500 Message-ID: <50CA3A0D.50100@redhat.com> Date: Thu, 13 Dec 2012 20:27:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: Andreas Tobler CC: gdb-patches@sourceware.org Subject: Re: [PATCH] FreeBSD powerpc support References: <50AAA80B.1000509@fgznet.ch> <50AFCF95.1080809@redhat.com> <50B4FC29.9050006@fgznet.ch> <50C79283.1050608@redhat.com> <50C8E3EA.1050300@fgznet.ch> <50CA34A1.3080606@redhat.com> <50CA3892.3040807@fgznet.ch> In-Reply-To: <50CA3892.3040807@fgznet.ch> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-12/txt/msg00473.txt.bz2 On 12/13/2012 08:20 PM, Andreas Tobler wrote: > On 13.12.12 21:03, Pedro Alves wrote: >> On 12/12/2012 08:07 PM, Andreas Tobler wrote: >>> If you're ok I try to update the patch with a new file which contains >>> the 'common' code for ppc64. >> >> FAOD, I'm fine with that. > > Ok. Thinking a bit more about makes me feel that a separate patch would > be more clean. Iow, a patch which extracts the 'common' functions from > ppc-linux-tdep.c into ppc64-common-tdep.c. > > Once this is tested (ppc64-linux) and in, I can bring the FreeBSD > support on top of it. > > Mixing these two issues together might cause troubles.... > > Do you agree? That's fine, but it'd make sense to see both patches together, so we don't have to imagine the uses outside GNU/Linux. This is where quilt or git would pay off a lot for you. The reverse would be fine with me too. Extract the commonality after the FreeBSD patch is in. -- Pedro Alves