Re: [PATCH] FreeBSD powerpc support

Pedro Alves
2012-12-13T20:27:15Z

On 12/13/2012 08:20 PM, Andreas Tobler wrote:
> On 13.12.12 21:03, Pedro Alves wrote:
>> On 12/12/2012 08:07 PM, Andreas Tobler wrote:
>>> If you're ok I try to update the patch with a new file which contains
>>> the 'common' code for ppc64.
>>
>> FAOD, I'm fine with that.
>
> Ok. Thinking a bit more about makes me feel that a separate patch would
> be more clean. Iow, a patch which extracts the 'common' functions from
> ppc-linux-tdep.c into ppc64-common-tdep.c.
>
> Once this is tested (ppc64-linux) and in, I can bring the FreeBSD
> support on top of it.
>
> Mixing these two issues together might cause troubles....
>
> Do you agree?

That's fine, but it'd make sense to see both patches together, so we
don't have to imagine the uses outside GNU/Linux. This is where quilt
or git would pay off a lot for you.
The reverse would be fine with me too. Extract the commonality after
the FreeBSD patch is in.

--
Pedro Alves