From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31443 invoked by alias); 13 Dec 2012 14:32:49 -0000 Received: (qmail 31433 invoked by uid 22791); 13 Dec 2012 14:32:47 -0000 X-SWARE-Spam-Status: No, hits=-7.6 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 13 Dec 2012 14:32:44 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qBDEWeKv019366 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 13 Dec 2012 09:32:40 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id qBDEWcLj026119; Thu, 13 Dec 2012 09:32:39 -0500 Message-ID: <50C9E706.2020708@redhat.com> Date: Thu, 13 Dec 2012 14:32:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: Pierre Muller , GDB Patches Subject: Re: [RFC-v5] Fix .text section offset for windows DLL (was Calling __stdcall functions in the inferior) References: <20121024194517.GK3555@adacore.com> <011901cdb2ab$48076b90$d81642b0$@muller@ics-cnrs.unistra.fr> <20121105171121.GA2972@adacore.com> <50991f5f.8382440a.1100.ffff82abSMTPIN_ADDED@mx.google.com> <509ABA17.30507@redhat.com> <000301cdbd96$f5cd9f10$e168dd30$@muller@ics-cnrs.unistra.fr> <20121122173019.GF9964@adacore.com> <15690.5992342674$1353883881@news.gmane.org> <87624si9ur.fsf@fleche.redhat.com> <001501cdccaf$ad85e9b0$0891bd10$@muller@ics-cnrs.unistra.fr> <20121207071035.GG31477@adacore.com> <50C20A66.70002@gmail.com> <29545.4593528577$1354894901@news.gmane.org> <50C21696.7040006@gmail.com> <50c21914.a750420a.2ec3.ffffe4ffSMTPIN_ADDED_BROKEN@mx.google.com> <50C222D5.4000802@redhat.com> <50C22C20.8090906@redhat.com> <008101cdd920$907e7580$b17b6080$@muller@ics-cnrs.unistra.fr> <50C9B6E0.1050709@redhat.com> <00a201cdd931$b0ee13f0$12ca3bd0$@muller@ics-cnrs.unistra.fr> In-Reply-To: <00a201cdd931$b0ee13f0$12ca3bd0$@muller@ics-cnrs.unistra.fr> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-12/txt/msg00445.txt.bz2 On 12/13/2012 12:59 PM, Pierre Muller wrote: >> >>> Pedro, >> I'm still curious on why you needed the #ifndefs though. > > Oh, I forgot that one, > I will test without the ifdef's... > These across are defined in mingw32 winnh.h header > and also for cygwin in > /usr/include/aout.h > /usr/include/w32api/winnt.h > as well as in > /usr/include/w32api/ddk/ntimage.h > > and I was afraid that such a header could be included indirectly > by some of the other headers. I don't think that's very likely. That'd mean that coff/pe.h would need guards for its related definitions too. > Below is a patch to remove the unneeded checks... > > 2012-12-13 Pierre Muller > > * coff-pe-read.c (IMAGE_SCN_CNT_TEXT, IMAGE_SCN_CNT_INITIALIZED_DATA) > (IMAGE_SCN_CNT_UNINITIALIZED_DATA): Remove useless checks > for already defined macros. > > Index: coff-pe-read.c > =================================================================== > RCS file: /cvs/src/src/gdb/coff-pe-read.c,v > retrieving revision 1.19 > diff -u -p -r1.19 coff-pe-read.c > --- coff-pe-read.c 13 Dec 2012 10:44:45 -0000 1.19 > +++ coff-pe-read.c 13 Dec 2012 12:46:09 -0000 > @@ -55,15 +55,9 @@ struct read_pe_section_data > char *section_name; /* Recorded section name. */ > }; > > -#ifndef IMAGE_SCN_CNT_CODE > # define IMAGE_SCN_CNT_CODE 0x20 The spaces in "# define" should be removed too. Okay with that change. > -#endif > -#ifndef IMAGE_SCN_CNT_INITIALIZED_DATA > # define IMAGE_SCN_CNT_INITIALIZED_DATA 0x40 > -#endif > -#ifndef IMAGE_SCN_CNT_UNINITIALIZED_DATA > # define IMAGE_SCN_CNT_UNINITIALIZED_DATA 0x80 > -#endif -- Pedro Alves