From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 762 invoked by alias); 13 Dec 2012 10:32:33 -0000 Received: (qmail 752 invoked by uid 22791); 13 Dec 2012 10:32:33 -0000 X-SWARE-Spam-Status: No, hits=-7.6 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 13 Dec 2012 10:32:27 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qBDAWPH0022190 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 13 Dec 2012 05:32:25 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id qBDAWOkH028033; Thu, 13 Dec 2012 05:32:24 -0500 Message-ID: <50C9AEB7.60706@redhat.com> Date: Thu, 13 Dec 2012 10:32:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: Joel Brobecker CC: gdb-patches@sourceware.org Subject: Re: [commit/obv] Remove trailing space in gdbarch.sh. References: <1355320564-6481-1-git-send-email-brobecker@adacore.com> <50C8A3CD.3000608@redhat.com> <20121213054613.GC3578@adacore.com> In-Reply-To: <20121213054613.GC3578@adacore.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-12/txt/msg00433.txt.bz2 On 12/13/2012 05:46 AM, Joel Brobecker wrote: > This is my evil twin :-). :-) >> 2012-12-12 Pedro Alves >> >> * gdbarch.sh (do_read): Set IFS to blank. > > Looks good to me. > > Good analysis, as /bin/sh is indeed a link to dash on my laptop. Thanks for confirming. I've applied it now, with an added comment. 2012-12-13 Pedro Alves * gdbarch.sh (do_read): Set IFS to blank. --- gdb/gdbarch.sh | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/gdb/gdbarch.sh b/gdb/gdbarch.sh index 887552e..8a56106 100755 --- a/gdb/gdbarch.sh +++ b/gdb/gdbarch.sh @@ -47,7 +47,10 @@ do_read () { comment="" class="" - while read line + # On some SH's, 'read' trims leading and trailing whitespace by + # default (e.g., bash), while on others (e.g., dash), it doesn't. + # Set IFS to empty to disable the trimming everywhere. + while IFS='' read line do if test "${line}" = "" then