From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10445 invoked by alias); 12 Dec 2012 19:17:33 -0000 Received: (qmail 10354 invoked by uid 22791); 12 Dec 2012 19:17:33 -0000 X-SWARE-Spam-Status: No, hits=-7.6 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 12 Dec 2012 19:17:29 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qBCJHPYV011504 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 12 Dec 2012 14:17:25 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id qBCJHN8a013684; Wed, 12 Dec 2012 14:17:24 -0500 Message-ID: <50C8D843.1000008@redhat.com> Date: Wed, 12 Dec 2012 19:17:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: Eli Zaretskii CC: yao@codesourcery.com, gdb-patches@sourceware.org Subject: Re: [PATCH 4/8] command 'set debug notification'. References: <1355208017-9204-1-git-send-email-yao@codesourcery.com> <1355208017-9204-5-git-send-email-yao@codesourcery.com> <83r4mx9ifb.fsf@gnu.org> <50C8C564.6090405@redhat.com> <83zk1j6qrc.fsf@gnu.org> In-Reply-To: <83zk1j6qrc.fsf@gnu.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-12/txt/msg00423.txt.bz2 On 12/12/2012 06:59 PM, Eli Zaretskii wrote: >> Date: Wed, 12 Dec 2012 17:56:52 +0000 >> From: Pedro Alves >> CC: Yao Qi , gdb-patches@sourceware.org >> >> On 12/11/2012 07:06 AM, Eli Zaretskii wrote: >>> >>>>> + add_setshow_boolean_cmd ("notification", no_class, ¬if_debug, >>>>> + _("\ >>>>> +Set debugging of async remote notification."), _("\ >>>>> +Show debugging of async remote notification."), _("\ >>>>> +When non-zero, async remote notification specific" >>>>> +" internal debugging is enabled."), >>> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ >>> I think not "debugging" is enabled, but "debugging info" is enabled. >> >> This command just enables/disables internal debugging/logging output, >> it is not about debug info, as in dwarf, etc. > > Granted, I understand that. If you suggest to say > > When non-zero, debugging output about async remote notifications is > enabled. > > then I have no objections. But saying that "internal debugging is > enabled" is certainly inaccurate and perhaps even misleading, IMO. I like that text, thanks. Yao, the code parts are okay with that change. Thanks, -- Pedro Alves