From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10332 invoked by alias); 12 Dec 2012 18:28:04 -0000 Received: (qmail 10313 invoked by uid 22791); 12 Dec 2012 18:28:02 -0000 X-SWARE-Spam-Status: No, hits=-7.6 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 12 Dec 2012 18:27:53 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qBCIRoPr029523 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 12 Dec 2012 13:27:51 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id qBCIKFcH003033; Wed, 12 Dec 2012 13:20:18 -0500 Message-ID: <50C8CADF.5060503@redhat.com> Date: Wed, 12 Dec 2012 18:28:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: Yao Qi CC: gdb-patches@sourceware.org Subject: Re: [PATCH 6/8] Handle notification for all-stop. References: <1355208017-9204-1-git-send-email-yao@codesourcery.com> <1355208017-9204-7-git-send-email-yao@codesourcery.com> In-Reply-To: <1355208017-9204-7-git-send-email-yao@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-12/txt/msg00417.txt.bz2 On 12/11/2012 06:40 AM, Yao Qi wrote: > @@ -5785,7 +5786,15 @@ remote_wait_as (ptid_t ptid, struct target_waitstatus *status, int options) > _never_ wait for ever -> test on target_is_async_p(). > However, before we do that we need to ensure that the caller > knows how to take the target into/out of async mode. */ > - ret = getpkt_sane (&rs->buf, &rs->buf_size, wait_forever_enabled_p); > + ret = getpkt_or_notif_sane (&rs->buf, &rs->buf_size, > + wait_forever_enabled_p, &is_notif); > + > + if (ret != -1 && is_notif) > + { > + /* The target didn't really stop; keep waiting. */ > + rs->waiting_for_stop_reply = 1; Why do we need to set this here? It's only cleared a bit below? > + return minus_one_ptid; > + } > if (!target_is_async_p ()) > signal (SIGINT, ofunc); > } -- Pedro Alves