From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14197 invoked by alias); 12 Dec 2012 17:05:58 -0000 Received: (qmail 14179 invoked by uid 22791); 12 Dec 2012 17:05:55 -0000 X-SWARE-Spam-Status: No, hits=-7.6 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 12 Dec 2012 17:05:46 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qBCH5h5T003506 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 12 Dec 2012 12:05:43 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id qBCH5ftT023082; Wed, 12 Dec 2012 12:05:42 -0500 Message-ID: <50C8B965.8000204@redhat.com> Date: Wed, 12 Dec 2012 17:05:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: Yao Qi CC: gdb-patches@sourceware.org Subject: Re: [PATCH 1/8] new queue.h in common/. References: <1355208017-9204-1-git-send-email-yao@codesourcery.com> <1355208017-9204-2-git-send-email-yao@codesourcery.com> In-Reply-To: <1355208017-9204-2-git-send-email-yao@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-12/txt/msg00411.txt.bz2 On 12/11/2012 06:40 AM, Yao Qi wrote: > Hi, > When writing the patches for 'general notification', I find queue is > used in many places, so I think we may need a general queue. This > queue not only have typical operations enqueue and dequeue, but also > has some have some operations like remove and remove_all. > > In V4, Pedro's comments are addressed, and the macros are moved from > the bottom of file to the top, along with comments. Thanks, I have no further comments. -- Pedro Alves