From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1553 invoked by alias); 12 Dec 2012 12:44:32 -0000 Received: (qmail 1542 invoked by uid 22791); 12 Dec 2012 12:44:31 -0000 X-SWARE-Spam-Status: No, hits=-7.6 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 12 Dec 2012 12:44:28 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qBCCiPVr008448 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 12 Dec 2012 07:44:25 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id qBCCiN3I020576; Wed, 12 Dec 2012 07:44:24 -0500 Message-ID: <50C87C27.7050101@redhat.com> Date: Wed, 12 Dec 2012 12:44:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: Pierre Muller CC: gdb-patches@sourceware.org Subject: Re: [RFA] Make contrib/ari/gdb_find.sh script more configurable References: <50c72eb9.c7f1440a.18e7.ffff89d4SMTPIN_ADDED_BROKEN@mx.google.com> In-Reply-To: <50c72eb9.c7f1440a.18e7.ffff89d4SMTPIN_ADDED_BROKEN@mx.google.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-12/txt/msg00385.txt.bz2 On 12/11/2012 01:01 PM, Pierre Muller wrote: > As we were talking about adding > gdbserver to the list of directories that should > also be inspected by Awk regression scripts, > I propose hereby a patch allowing to include directory > gdbtk, gdbserver or gnulib to the list of inspected directories > by simply exporting a variable named check_XXX_dir > before running the scripts. IMO, if you're going to support something like this, I think it'd make more sense to make it a single variable that accepts a list of dirs, like: ARI_CHECK_EXTRA_DIRS=gdbtk,gdbserver,gnulib,whatnot or the CLI version --check-extra-dirs=gdbtk,gdbserver,gnulib,whatnot or some such. >From reading the patch, I find no real need to hardcode the set of possible dirs. -- Pedro Alves