From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2924 invoked by alias); 12 Dec 2012 12:03:24 -0000 Received: (qmail 2914 invoked by uid 22791); 12 Dec 2012 12:03:24 -0000 X-SWARE-Spam-Status: No, hits=-7.6 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 12 Dec 2012 12:03:10 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qBCC38Er005958 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 12 Dec 2012 07:03:09 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id qBCC36Yh012196; Wed, 12 Dec 2012 07:03:08 -0500 Message-ID: <50C8727A.7050002@redhat.com> Date: Wed, 12 Dec 2012 12:03:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: Yao Qi CC: gdb-patches@sourceware.org Subject: Re: [PATCH 1/6] Add a field 'installed' for each location of tracepoint. References: <1354596282-32526-1-git-send-email-yao@codesourcery.com> <1354596282-32526-2-git-send-email-yao@codesourcery.com> <50C10675.3000405@redhat.com> <50C488D0.8010609@codesourcery.com> <50C76C9C.70207@redhat.com> <50C7E3CB.5030706@codesourcery.com> In-Reply-To: <50C7E3CB.5030706@codesourcery.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-12/txt/msg00381.txt.bz2 On 12/12/2012 01:54 AM, Yao Qi wrote: > On 12/12/2012 01:25 AM, Pedro Alves wrote: >>> + if (!header_of_multiple && loc != NULL && !loc->shlib_disabled) >>> >+ { >>> >+ annotate_field (11); >>> >+ >>> >+ if (ui_out_is_mi_like_p (uiout)) >>> >+ ui_out_field_string (uiout, "installed", >>> >+ loc->inserted ? "y" : "n"); >>> >+ else >>> >+ { >>> >+ if (loc->inserted) >>> >+ ui_out_text (uiout, "\t"); >>> >+ else >>> >+ ui_out_text (uiout, "\tnot "); >>> >+ ui_out_text (uiout, "installed on target\n"); >>> >+ } >>> >+ } >>> > } >> Wait, what is making sure this is only printed for tracepoints? > > This part of code 'shares' the same condition check > 'if (is_tracepoint (b))' with the code printing 'pass count'. However, it is invisible in the patch itself. I see, thanks. Patch is OK. -- Pedro Alves