From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12269 invoked by alias); 12 Dec 2012 01:54:29 -0000 Received: (qmail 12260 invoked by uid 22791); 12 Dec 2012 01:54:28 -0000 X-SWARE-Spam-Status: No, hits=-4.6 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 12 Dec 2012 01:54:20 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1TibWd-0000c6-On from Yao_Qi@mentor.com ; Tue, 11 Dec 2012 17:54:19 -0800 Received: from SVR-ORW-FEM-03.mgc.mentorg.com ([147.34.97.39]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Tue, 11 Dec 2012 17:54:19 -0800 Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-03.mgc.mentorg.com (147.34.97.39) with Microsoft SMTP Server id 14.1.289.1; Tue, 11 Dec 2012 17:54:18 -0800 Message-ID: <50C7E3CB.5030706@codesourcery.com> Date: Wed, 12 Dec 2012 01:54:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:15.0) Gecko/20120911 Thunderbird/15.0.1 MIME-Version: 1.0 To: Pedro Alves CC: Subject: Re: [PATCH 1/6] Add a field 'installed' for each location of tracepoint. References: <1354596282-32526-1-git-send-email-yao@codesourcery.com> <1354596282-32526-2-git-send-email-yao@codesourcery.com> <50C10675.3000405@redhat.com> <50C488D0.8010609@codesourcery.com> <50C76C9C.70207@redhat.com> In-Reply-To: <50C76C9C.70207@redhat.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-12/txt/msg00371.txt.bz2 On 12/12/2012 01:25 AM, Pedro Alves wrote: >> + if (!header_of_multiple && loc != NULL && !loc->shlib_disabled) >> >+ { >> >+ annotate_field (11); >> >+ >> >+ if (ui_out_is_mi_like_p (uiout)) >> >+ ui_out_field_string (uiout, "installed", >> >+ loc->inserted ? "y" : "n"); >> >+ else >> >+ { >> >+ if (loc->inserted) >> >+ ui_out_text (uiout, "\t"); >> >+ else >> >+ ui_out_text (uiout, "\tnot "); >> >+ ui_out_text (uiout, "installed on target\n"); >> >+ } >> >+ } >> > } > Wait, what is making sure this is only printed for tracepoints? This part of code 'shares' the same condition check 'if (is_tracepoint (b))' with the code printing 'pass count'. However, it is invisible in the patch itself. -- Yao (齐尧)