From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10293 invoked by alias); 11 Dec 2012 16:45:07 -0000 Received: (qmail 10161 invoked by uid 22791); 11 Dec 2012 16:45:00 -0000 X-SWARE-Spam-Status: No, hits=-7.6 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 11 Dec 2012 16:44:56 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qBBGis0P003258 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 11 Dec 2012 11:44:55 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id qBBGir3B030927; Tue, 11 Dec 2012 11:44:53 -0500 Message-ID: <50C76305.8080800@redhat.com> Date: Tue, 11 Dec 2012 16:45:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: Mark Kettenis CC: brobecker@adacore.com, gdb-patches@sourceware.org Subject: Re: [PATCH 1/2] Put a NT_PSTATUS note on solaris cores. References: <50C6115C.4090509@redhat.com> <20121210180216.3932.48633.stgit@brno.lan> <20121211030352.GB13565@adacore.com> <50C72573.5060305@redhat.com> <20121211151136.GQ31477@adacore.com> <201212111516.qBBFGR58001045@glazunov.sibelius.xs4all.nl> In-Reply-To: <201212111516.qBBFGR58001045@glazunov.sibelius.xs4all.nl> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-12/txt/msg00346.txt.bz2 On 12/11/2012 03:16 PM, Mark Kettenis wrote: >> Date: Tue, 11 Dec 2012 19:11:36 +0400 >> From: Joel Brobecker >> >>> You're doing the right test. The issue is that core_pid_to_str >>> calls into the gdbarch_core_pid_to_str, and that isn't expecting >>> to be passed a "process pid" instead of an "LWP pid". >>> >>> Could you try this one when you have a chance? This is rebased on >>> top of current mainline, so it restores the elfcore_write_pstatus >>> call that the Unixware-excise patch removed. I made sure it builds with >>> --enable-targets=all. >> >> Nice detective work :) Nah, it was obvious to me what the problem was. :-) >> >> (gdb) core core.26444 >> [New LWP 1] >> Core was generated by `/[...]/simple_main'. >> Program terminated with signal 5, Trace/breakpoint trap. >> #0 simple_main () at simple_main.adb:4 >> 4 simple.test_simple; >> (gdb) info inferiors >> Num Description Executable >> * 1 process 26444 /[...]/simple_main >> >> And with an older core file, since your patch handles it too: >> >> (gdb) info inferiors >> Num Description Executable >> * 1 /[...]/simple_main >> >> I tested the patch against our testsuite again, no regression either. >> So it looks all good to go! Great! > > FWIIW, this is fine with me as well (both the Unixware removal and > fixing the Solaris core dump stuff). > Thanks a lot guys. Everything's checked in now. -- Pedro Alves