On 12/11/2012 01:20 AM, Tom Tromey wrote: >>>>>> "Ali" == ali anwar writes: > > Ali> + if (thread_count ()) > Ali> + { > Ali> + struct thread_info tp_array [thread_count ()]; > > You can't use variable-length arrays in gdb. > Probably xmalloc and a cleanup is your best option here. > Removed the array, now using xmalloc and xfree. > Ali> + for(k = 0; k != i; k++) > > Space between 'for' and '('. > Added a space. > Ali> + switch_to_thread ((&tp_array [k])->ptid); > > No space before '['. This occurs in a couple places. > Removed a space. > Tom > Thanks for the review. PFA the modified patch. Regards, -Ali