Re: [PATCH 1/6] Add a field 'installed' for each location of tracepoint.

Pedro Alves
2012-12-12T12:03:24Z

On 12/12/2012 01:54 AM, Yao Qi wrote:
> On 12/12/2012 01:25 AM, Pedro Alves wrote:
>>> + if (!header_of_multiple && loc != NULL && !loc->shlib_disabled)
>>> >+ {
>>> >+ annotate_field (11);
>>> >+
>>> >+ if (ui_out_is_mi_like_p (uiout))
>>> >+ ui_out_field_string (uiout, "installed",
>>> >+ loc->inserted ? "y" : "n");
>>> >+ else
>>> >+ {
>>> >+ if (loc->inserted)
>>> >+ ui_out_text (uiout, "\t");
>>> >+ else
>>> >+ ui_out_text (uiout, "\tnot ");
>>> >+ ui_out_text (uiout, "installed on target\n");
>>> >+ }
>>> >+ }
>>> > }
>> Wait, what is making sure this is only printed for tracepoints?
>
> This part of code 'shares' the same condition check
> 'if (is_tracepoint (b))' with the code printing 'pass count'. However, it is invisible in the patch itself.

I see, thanks.

Patch is OK.

--
Pedro Alves