[PATCH 0/6] Add a new field 'installed' when reporting tracepoint

Yao Qi
2012-12-04T04:45:14Z

Hello,
During the review to 'tracepoint download' notification
<http://sourceware.org/ml/gdb-patches/2012-11/msg00871.html>, we find it is
better to treat 'installed on target' as an attribute of a tracepoint,
and breakpoint related notification can report it, instead of a
separate notification.

In this patch series, we add a field 'installed' in
print_one_breakpoint_location, which is a boolean to show "y" or "n" the
tracepoint is installed on target. The field reflects the value of
'inserted' field of each location.

Originally, my proposal is for MI notification, but I think it also
useful to display the state of 'installed' in the output of CLI. With
this series applied, we can see the 'installed' state in both CLI and
MI.

The 'installed' field is not shown for non-tracepoint breakpoint,
because in most of cases, breakpoints are inserted when to resume
inferior, and removed when inferior stops.

1/6 Add a field 'installed' for each location of tracepoint.
2/6 Iterate over ALL_TRACEPOINTS first.
3/6 Notify breakpoint-modified when tracepoints are downloaded.
4/6 Notify breakpoint-modified when uploaded tracepoints are merged.
5/6 Test tracepoints are installed or not
6/6 Update test cases for 'installed' field.

Patch 1/6 adds the new field 'installed' in
print_one_breakpoint_location, and patch 2/6 - 4/6 call
breakpoint-modified observer when the 'inserted' flag is changed. Patch
5/6 is to test this feature, and patch 6/6 is update existing tests for
the new output of 'info breakpoint' or 'info tracepoint'.

The whole series are tested on x86_linux both native and gdbserver. Is
it OK?

gdb/breakpoint.c | 48 ++++++++++++++-------
gdb/testsuite/gdb.trace/actions.exp | 25 +++++++++--
gdb/testsuite/gdb.trace/change-loc.exp | 6 ++-
gdb/testsuite/gdb.trace/deltrace.exp | 22 +++++++--
gdb/testsuite/gdb.trace/infotrace.exp | 10 +++-
gdb/testsuite/gdb.trace/mi-traceframe-changed.exp | 3 +-
gdb/testsuite/gdb.trace/mi-tracepoint-changed.exp | 20 +++++++-
gdb/testsuite/gdb.trace/passcount.exp | 28 +++++++++---
gdb/testsuite/gdb.trace/tracecmd.exp | 13 ++++--
gdb/testsuite/gdb.trace/while-stepping.exp | 3 +-
gdb/tracepoint.c | 33 ++++++++++++++
11 files changed, 163 insertions(+), 48 deletions(-)

--
1.7.7.6