Re: [PATCH 1/6] Add a field 'installed' for each location of tracepoint.

Yao Qi
2012-12-07T13:49:39Z

On 12/07/2012 04:56 AM, Pedro Alves wrote:
> 2 tracepoint keep y 0x080485b1 in main at gdb.trace/change-loc.c:29
> installed on target
> 3 tracepoint keep y 0x080485b1 in main at gdb.trace/change-loc.c:29
> not installed on target
>

That is good to me.

> This should be documented in the manual and NEWS, both the CLI changes, and
> the MI change (this patch adds the "installed" field to various MI things).
>

Will do.

>> >+
>> >+ if (!header_of_multiple)
>> >+ {
>> >+ annotate_field (11);
>> >+ ui_out_text (uiout, "\tinstalled ");
>> >+ /* LOC is NULL means the tracepoint is still pending, set
>> >+ field 'installed' 'n'. */
>> >+ ui_out_field_string (uiout, "installed",
>> >+ loc ? (loc->inserted ? "y" : "n") : "n");
>> >+ ui_out_text (uiout, " \n");
> Not sure about the pending case. Can you show how does that look like?

It shows pending tracepoint like this,

Num Type Disp Enb Address What
1 tracepoint keep y <PENDING> foo
installed n

> Why not just display nothing in that case? How does the MI output look
> like in the pending case?
>

Right, it makes few sense to display the 'installed' field for pending
tracepoint, as it doesn't have any locations at all. I'll update the
patch to display 'installed' field for non-pending tracepoints.

--
Yao (é½å°§)