From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23878 invoked by alias); 7 Dec 2012 22:12:46 -0000 Received: (qmail 23868 invoked by uid 22791); 7 Dec 2012 22:12:45 -0000 X-SWARE-Spam-Status: No, hits=-7.6 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 07 Dec 2012 22:12:38 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qB7MCbUp016354 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 7 Dec 2012 17:12:37 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id qB7MCamt023908; Fri, 7 Dec 2012 17:12:36 -0500 Message-ID: <50C269D3.10306@redhat.com> Date: Fri, 07 Dec 2012 22:12:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: Tom Tromey CC: gdb-patches@sourceware.org Subject: Re: [3/3] RFC: tag name completion References: <87obiqlrv7.fsf@fleche.redhat.com> In-Reply-To: <87obiqlrv7.fsf@fleche.redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-12/txt/msg00210.txt.bz2 On 11/21/2012 06:42 PM, Tom Tromey wrote: > This implements tag name completion in the C parser. > > The basic idea is simple: if the user enters "struct X", then only > struct tags starting with "X" should be considered. (And likewise for > class, enum, and union.) I think this is a good idea. I'm not that much familiar with this part of the code. I'm just wondering about struct vs class. GDB treats both mostly interchangeably, e.g., with "struct ABC {};", ptype "class ABC" will find and print the struct. Would "class A" still complete to "class ABC" with this patch? -- Pedro Alves