From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28959 invoked by alias); 7 Dec 2012 13:49:39 -0000 Received: (qmail 28949 invoked by uid 22791); 7 Dec 2012 13:49:37 -0000 X-SWARE-Spam-Status: No, hits=-4.5 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 07 Dec 2012 13:49:32 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1TgyJ1-0000Xv-S3 from Yao_Qi@mentor.com ; Fri, 07 Dec 2012 05:49:31 -0800 Received: from SVR-ORW-FEM-02.mgc.mentorg.com ([147.34.96.206]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Fri, 7 Dec 2012 05:49:31 -0800 Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-02.mgc.mentorg.com (147.34.96.168) with Microsoft SMTP Server id 14.1.289.1; Fri, 7 Dec 2012 05:49:30 -0800 Message-ID: <50C1F3E0.5000309@codesourcery.com> Date: Fri, 07 Dec 2012 13:49:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:15.0) Gecko/20120911 Thunderbird/15.0.1 MIME-Version: 1.0 To: Pedro Alves CC: Subject: Re: [PATCH 1/6] Add a field 'installed' for each location of tracepoint. References: <1354596282-32526-1-git-send-email-yao@codesourcery.com> <1354596282-32526-2-git-send-email-yao@codesourcery.com> <50C10675.3000405@redhat.com> In-Reply-To: <50C10675.3000405@redhat.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-12/txt/msg00165.txt.bz2 On 12/07/2012 04:56 AM, Pedro Alves wrote: > 2 tracepoint keep y 0x080485b1 in main at gdb.trace/change-loc.c:29 > installed on target > 3 tracepoint keep y 0x080485b1 in main at gdb.trace/change-loc.c:29 > not installed on target > That is good to me. > This should be documented in the manual and NEWS, both the CLI changes, and > the MI change (this patch adds the "installed" field to various MI things). > Will do. >> >+ >> >+ if (!header_of_multiple) >> >+ { >> >+ annotate_field (11); >> >+ ui_out_text (uiout, "\tinstalled "); >> >+ /* LOC is NULL means the tracepoint is still pending, set >> >+ field 'installed' 'n'. */ >> >+ ui_out_field_string (uiout, "installed", >> >+ loc ? (loc->inserted ? "y" : "n") : "n"); >> >+ ui_out_text (uiout, " \n"); > Not sure about the pending case. Can you show how does that look like? It shows pending tracepoint like this, Num Type Disp Enb Address What 1 tracepoint keep y foo installed n > Why not just display nothing in that case? How does the MI output look > like in the pending case? > Right, it makes few sense to display the 'installed' field for pending tracepoint, as it doesn't have any locations at all. I'll update the patch to display 'installed' field for non-pending tracepoints. -- Yao (齐尧)