From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3926 invoked by alias); 7 Dec 2012 10:18:57 -0000 Received: (qmail 3918 invoked by uid 22791); 7 Dec 2012 10:18:56 -0000 X-SWARE-Spam-Status: No, hits=-7.6 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 07 Dec 2012 10:18:47 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qB7AIlQp008922 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 7 Dec 2012 05:18:47 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id qB7AIjvW011496; Fri, 7 Dec 2012 05:18:46 -0500 Message-ID: <50C1C285.5070904@redhat.com> Date: Fri, 07 Dec 2012 10:18:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: Tom Tromey CC: gdb-patches@sourceware.org Subject: Re: RFC: automatic dependency tracking for gdbserver References: <87r4n6vnqx.fsf@fleche.redhat.com> In-Reply-To: <87r4n6vnqx.fsf@fleche.redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-12/txt/msg00142.txt.bz2 On 12/03/2012 09:17 PM, Tom Tromey wrote: > This patch applies the same automatic dependency tracking logic that gdb > uses to gdbserver. > > The downside of this patch is that gdbserver dependencies will not be > tracked unless the developer is using GNU make. On the other hand, > we've had this same code in gdb for several years without any > complaints. > > Comments? Err, I love you? :-) Seriously, many thanks for doing this. > +amd64-linux-ipa.o : amd64-linux.c Spurious space -----^ > diff --git a/gdb/gdbserver/aclocal.m4 b/gdb/gdbserver/aclocal.m4 > index 7b546b7..55bf0d8 100644 > --- a/gdb/gdbserver/aclocal.m4 > +++ b/gdb/gdbserver/aclocal.m4 > @@ -106,4 +106,6 @@ AC_DEFUN([_AM_SUBST_NOTMAKE]) > # Public sister of _AM_SUBST_NOTMAKE. > AC_DEFUN([AM_SUBST_NOTMAKE], [_AM_SUBST_NOTMAKE($@)]) > > +m4_include([../../config/depstand.m4]) > +m4_include([../../config/lead-dot.m4]) > m4_include([acinclude.m4]) I think I'd mildly prefer having these listed explicitly in acinclude.m4, so you can do just autoreconf on the command line or aclocal, without worrying about forgetting -I (IIRC, ACLOCAL_AMFLAGS is actually ignored, because we're not using automake). WDYT? I actually have a patch for GDB that does the same to gdb's aclocal. See the second patch at: https://github.com/palves/gdb/commits/aclocal but I never posted it. I do wonder why does acinclude.m4 use sinclude instead of include. I don't see why you'd ever want those includes to silently fail. -- Pedro Alves