From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-96664-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 23267 invoked by alias); 7 Dec 2012 09:56:36 -0000
Received: (qmail 23251 invoked by uid 22791); 7 Dec 2012 09:56:35 -0000
X-SWARE-Spam-Status: No, hits=-7.6 required=5.0	tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 07 Dec 2012 09:56:26 +0000
Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qB79uOfh004639	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Fri, 7 Dec 2012 04:56:24 -0500
Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11])	by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id qB79uMM0007387;	Fri, 7 Dec 2012 04:56:22 -0500
Message-ID: <50C1BD45.9080709@redhat.com>
Date: Fri, 07 Dec 2012 09:56:00 -0000
From: Pedro Alves <palves@redhat.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0
MIME-Version: 1.0
To: Hui Zhu <teawater@gmail.com>
CC: Tom Tromey <tromey@redhat.com>,        gdb-patches ml <gdb-patches@sourceware.org>,        Hui Zhu <hui_zhu@mentor.com>
Subject: Re: [PATCH] Add fseek to ui-file
References: <CANFwon0Nv=Dk7-1kmxwjwv9zd-qoWUL18mpqH9vazRzBnkd10g@mail.gmail.com> <87txryx36w.fsf@fleche.redhat.com> <CANFwon31+VCzVWBvDLQedK0EGatd6XrRxaH1LbnHUtEKA91Ciw@mail.gmail.com>
In-Reply-To: <CANFwon31+VCzVWBvDLQedK0EGatd6XrRxaH1LbnHUtEKA91Ciw@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-12/txt/msg00137.txt.bz2

On 12/07/2012 08:01 AM, Hui Zhu wrote:
> +ui_file_fseek (struct ui_file * file, long offset, int whence)

No space after '*'.  Several instances of this issue in the patch.

On 12/07/2012 08:01 AM, Hui Zhu wrote:
> +static void
> +stdio_file_fseek (struct ui_file * file, long offset, int whence)
> +{
...
> +  if (fseek (stdio->file, offset, whence))
> +    error (_("fseek fail: %s"), safe_strerror (errno));

I think that if we want to support error handling, then this should
return the fseek result to the caller instead of throwing an exception.
See e.g., the comment in stdio_file_write.

-- 
Pedro Alves