From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16134 invoked by alias); 6 Dec 2012 20:55:25 -0000 Received: (qmail 16126 invoked by uid 22791); 6 Dec 2012 20:55:24 -0000 X-SWARE-Spam-Status: No, hits=-7.6 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 06 Dec 2012 20:55:16 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qB6KtDow007877 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 6 Dec 2012 15:55:15 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id qB6Kt8ao025223; Thu, 6 Dec 2012 15:55:13 -0500 Message-ID: <50C1062B.6070500@redhat.com> Date: Thu, 06 Dec 2012 20:55:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: Yao Qi CC: gdb-patches@sourceware.org Subject: Re: [PATCH 0/6] Add a new field 'installed' when reporting tracepoint References: <1354596282-32526-1-git-send-email-yao@codesourcery.com> In-Reply-To: <1354596282-32526-1-git-send-email-yao@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-12/txt/msg00114.txt.bz2 On 12/04/2012 04:44 AM, Yao Qi wrote: > Hello, > During the review to 'tracepoint download' notification > , we find it is > better to treat 'installed on target' as an attribute of a tracepoint, > and breakpoint related notification can report it, instead of a > separate notification. > > In this patch series, we add a field 'installed' in > print_one_breakpoint_location, which is a boolean to show "y" or "n" the > tracepoint is installed on target. The field reflects the value of > 'inserted' field of each location. Thanks. > Originally, my proposal is for MI notification, but I think it also > useful to display the state of 'installed' in the output of CLI. With > this series applied, we can see the 'installed' state in both CLI and > MI. Absolutely. > > The 'installed' field is not shown for non-tracepoint breakpoint, > because in most of cases, breakpoints are inserted when to resume > inferior, and removed when inferior stops. Yeah. -- Pedro Alves