From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10314 invoked by alias); 6 Dec 2012 15:20:01 -0000 Received: (qmail 10188 invoked by uid 22791); 6 Dec 2012 15:19:59 -0000 X-SWARE-Spam-Status: No, hits=-3.5 required=5.0 tests=AWL,BAYES_00,KHOP_SPAMHAUS_DROP,KHOP_THREADED,RP_MATCHES_RCVD,TW_CP,TW_EG X-Spam-Check-By: sourceware.org Received: from usmamail.tilera.com (HELO USMAMAIL.TILERA.COM) (12.216.194.151) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 06 Dec 2012 15:19:54 +0000 Received: from [192.168.0.103] (106.3.102.46) by USMAExch2.tad.internal.tilera.com (10.3.0.33) with Microsoft SMTP Server (TLS) id 14.0.694.0; Thu, 6 Dec 2012 10:19:51 -0500 Message-ID: <50C0B790.9070509@tilera.com> Date: Thu, 06 Dec 2012 15:20:00 -0000 From: Jiong Wang User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: Yao Qi CC: , Walter Lee , Subject: Re: [PATCH/tilegx] tilegx bug fixes & improvements References: <50C04269.90304@tilera.com> <50C067CC.2050303@codesourcery.com> In-Reply-To: <50C067CC.2050303@codesourcery.com> Content-Type: multipart/mixed; boundary="------------080006000509070604080008" Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-12/txt/msg00109.txt.bz2 --------------080006000509070604080008 Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit Content-length: 1954 Hi Yao, >> - if (alignlen & 0x4) >> - stack_dest -= 4; >> + stack_dest = (stack_dest + 7) & ~0x7; > > Your can use function 'align_up'. fixed, and I do make a mistake here, should be align_down. >> /* Now write data to the stack. The stack grows downwards. */ >> stack_dest -= typelen + slacklen; >> write_memory (stack_dest, val, typelen + slacklen); >> - do_cleanups (back_to); > > alloca is unsafe, and we prefer to use xmalloc/cleanup+xfree. fixed. >> + if (status == 0) { >> + /* fix gdb.base/gdb1250 >> + * breakpoint is set before dynamic library loaded, thus >> gdb >> + * does a partial symbol name finding and sets the >> breakpoint >> + * in the plt stub. our 32-bundle prefetch window is too >> large >> + * for this situation to cause a memory access error. >> + * For plt stub, we just need to return directly. >> + * >> + * x86 does not have this problem, because the first >> instruction >> + * in their plt stub is jump, which ends the analysis also. >> + */ > > The comment style is not gnu style. fixed the comment style. > The problems looks about plt. I find tilegx port doesn't have a plt > stub unwinder. I am not sure creating a plt stub unwinder can fix > this problem, I am not quite understand the usage of plt stub unwinder here. i386 do not append plt stub unwinder also. from my understanding, those plt stub can be unwinded as normal frame, like a leaf function, or have I misunderstood something? > but it should fix other fails in testsuite. the left failures are mostly about type print issues under gdb.cp and gdb.python attachment is the patch to fix above problems thanks for feedback --- Regards, Jiong. Wang Tilera Corporation -- Regards, Salad office: +86-010-82825915, ext:653 cell: +86-13810021970 --------------080006000509070604080008 Content-Type: text/plain; charset="gb18030"; name="fix-glitches.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="fix-glitches.patch" Content-length: 3693 ZGlmZiAtLWdpdCBhL2dkYi90aWxlZ3gtdGRlcC5jIGIvZ2RiL3RpbGVneC10 ZGVwLmMKaW5kZXggZjdlMDBkNy4uOTAzYmYyMCAxMDA2NDQKLS0tIGEvZ2Ri L3RpbGVneC10ZGVwLmMKKysrIGIvZ2RiL3RpbGVneC10ZGVwLmMKQEAgLTMy NCwyMyArMzI0LDI3IEBAIHRpbGVneF9wdXNoX2R1bW15X2NhbGwgKHN0cnVj dCBnZGJhcmNoICpnZGJhcmNoLAogICAgIH0KIAogICAvKiBBbGlnbiBTUC4g ICovCi0gIHN0YWNrX2Rlc3QgPSAoc3RhY2tfZGVzdCArIDcpICYgfjB4NzsK KyAgc3RhY2tfZGVzdCA9IGFsaWduX2Rvd24oc3RhY2tfZGVzdCwgOCk7CiAK ICAgLyogTG9vcCBiYWNrd2FyZHMgdGhyb3VnaCByZW1haW5pbmcgYXJndW1l bnRzIGFuZCBwdXNoIHRoZW0gb24KICAgICAgdGhlIHN0YWNrLCB3b3JkIGFs aWduZWQuICAqLwogICBmb3IgKGogPSBuYXJncyAtIDE7IGogPj0gaTsgai0t KQogICAgIHsKICAgICAgIGdkYl9ieXRlICp2YWw7CisgICAgICBzdHJ1Y3Qg Y2xlYW51cCAqYmFja190bzsKKyAgICAgIGNvbnN0IGdkYl9ieXRlICpjb250 ZW50cyA9IHZhbHVlX2NvbnRlbnRzIChhcmdzW2pdKTsKIAogICAgICAgdHlw ZWxlbiA9IFRZUEVfTEVOR1RIICh2YWx1ZV9lbmNsb3NpbmdfdHlwZSAoYXJn c1tqXSkpOwogICAgICAgc2xhY2tsZW4gPSAoKHR5cGVsZW4gKyA3KSAmICh+ NykpIC0gdHlwZWxlbjsKLSAgICAgIHZhbCA9IGFsbG9jYSAodHlwZWxlbiAr IHNsYWNrbGVuKTsKLSAgICAgIG1lbWNweSAodmFsLCB2YWx1ZV9jb250ZW50 cyAoYXJnc1tqXSksIHR5cGVsZW4pOworICAgICAgdmFsID0geG1hbGxvYyAo dHlwZWxlbiArIHNsYWNrbGVuKTsKKyAgICAgIGJhY2tfdG8gPSBtYWtlX2Ns ZWFudXAgKHhmcmVlLCB2YWwpOworICAgICAgbWVtY3B5ICh2YWwsIGNvbnRl bnRzLCB0eXBlbGVuKTsKICAgICAgIG1lbXNldCAodmFsICsgdHlwZWxlbiwg MCwgc2xhY2tsZW4pOwogCiAgICAgICAvKiBOb3cgd3JpdGUgZGF0YSB0byB0 aGUgc3RhY2suICBUaGUgc3RhY2sgZ3Jvd3MgZG93bndhcmRzLiAgKi8KICAg ICAgIHN0YWNrX2Rlc3QgLT0gdHlwZWxlbiArIHNsYWNrbGVuOwogICAgICAg d3JpdGVfbWVtb3J5IChzdGFja19kZXN0LCB2YWwsIHR5cGVsZW4gKyBzbGFj a2xlbik7CisgICAgICBkb19jbGVhbnVwcyAoYmFja190byk7CiAgICAgfQog CiAgIC8qIEFkZCAyIGRvdWJsZSB3b3JkcyBmb3IgbGlua2FnZSBzcGFjZSB0 byB0aGUgc3RhY2suICAqLwpAQCAtNDM0LDE3ICs0MzgsMTYgQEAgdGlsZWd4 X2FuYWx5emVfcHJvbG9ndWUgKHN0cnVjdCBnZGJhcmNoKiBnZGJhcmNoLAog CQkJCQkgICAgIGluc3RidWYsIGluc3RidWZfc2l6ZSk7CiAJICBpZiAoc3Rh dHVzID09IDApIHsKICAgICAgICAgICAgIC8qIGZpeCBnZGIuYmFzZS9nZGIx MjUwCi0gICAgICAgICAgICAgKiBicmVha3BvaW50IGlzIHNldCBiZWZvcmUg ZHluYW1pYyBsaWJyYXJ5IGxvYWRlZCwgdGh1cyBnZGIKLSAgICAgICAgICAg ICAqIGRvZXMgYSBwYXJ0aWFsIHN5bWJvbCBuYW1lIGZpbmRpbmcgYW5kIHNl dHMgdGhlIGJyZWFrcG9pbnQKLSAgICAgICAgICAgICAqIGluIHRoZSBwbHQg c3R1Yi4gb3VyIDMyLWJ1bmRsZSBwcmVmZXRjaCB3aW5kb3cgaXMgdG9vIGxh cmdlCi0gICAgICAgICAgICAgKiBmb3IgdGhpcyBzaXR1YXRpb24gdG8gY2F1 c2UgYSBtZW1vcnkgYWNjZXNzIGVycm9yLgotICAgICAgICAgICAgICogRm9y IHBsdCBzdHViLCB3ZSBqdXN0IG5lZWQgdG8gcmV0dXJuIGRpcmVjdGx5Lgot ICAgICAgICAgICAgICoKLSAgICAgICAgICAgICAqIHg4NiBkb2VzIG5vdCBo YXZlIHRoaXMgcHJvYmxlbSwgYmVjYXVzZSB0aGUgZmlyc3QgaW5zdHJ1Y3Rp b24KLSAgICAgICAgICAgICAqIGluIHRoZWlyIHBsdCBzdHViIGlzIGp1bXAs IHdoaWNoIGVuZHMgdGhlIGFuYWx5c2lzIGFsc28uCisgICAgICAgICAgICAg ICBicmVha3BvaW50IGlzIHNldCBiZWZvcmUgZHluYW1pYyBsaWJyYXJ5IGxv YWRlZCwgdGh1cyBnZGIKKyAgICAgICAgICAgICAgIGRvZXMgYSBwYXJ0aWFs IHN5bWJvbCBuYW1lIGZpbmRpbmcgYW5kIHNldHMgdGhlIGJyZWFrcG9pbnQK KyAgICAgICAgICAgICAgIGluIHRoZSBwbHQgc3R1Yi4gb3VyIDMyLWJ1bmRs ZSBwcmVmZXRjaCB3aW5kb3cgaXMgdG9vIGxhcmdlCisgICAgICAgICAgICAg ICBmb3IgdGhpcyBzaXR1YXRpb24gdG8gY2F1c2UgYSBtZW1vcnkgYWNjZXNz IGVycm9yLgorICAgICAgICAgICAgICAgRm9yIHBsdCBzdHViLCB3ZSBqdXN0 IG5lZWQgdG8gcmV0dXJuIGRpcmVjdGx5LgorICAgICAgICAgICAgICAKKyAg ICAgICAgICAgICAgIHg4NiBkb2VzIG5vdCBoYXZlIHRoaXMgcHJvYmxlbSwg YmVjYXVzZSB0aGUgZmlyc3QgaW5zdHJ1Y3Rpb24KKyAgICAgICAgICAgICAg IGluIHRoZWlyIHBsdCBzdHViIGlzIGp1bXAsIHdoaWNoIGVuZHMgdGhlIGFu YWx5c2lzIGFsc28uCiAgICAgICAgICAgICAgKi8KLSAgICAgICAgICAgIGlm IChzdHJjbXAoZmluZF9wY19zZWN0aW9uKGluc3RidWZfc3RhcnQpLT50aGVf YmZkX3NlY3Rpb24tPm5hbWUsCi0gICAgICAgICAgICAgICAgICIucGx0Iikg PT0gMCkKKyAgICAgICAgICAgIGlmIChpbl9wbHRfc2VjdGlvbiAoaW5zdGJ1 Zl9zdGFydCwgTlVMTCkpCiAgICAgICAgICAgICAgIHJldHVybiBpbnN0YnVm X3N0YXJ0OwogICAgICAgICAgICAgbWVtb3J5X2Vycm9yIChzdGF0dXMsIG5l eHRfYWRkcik7CiAgICAgICAgICAgfQo= --------------080006000509070604080008--