From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24630 invoked by alias); 30 Nov 2012 14:11:16 -0000 Received: (qmail 24610 invoked by uid 22791); 30 Nov 2012 14:11:13 -0000 X-SWARE-Spam-Status: No, hits=-4.5 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 30 Nov 2012 14:11:09 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1TeRJ5-0004zI-Bs from Yao_Qi@mentor.com ; Fri, 30 Nov 2012 06:11:07 -0800 Received: from SVR-ORW-FEM-02.mgc.mentorg.com ([147.34.96.206]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Fri, 30 Nov 2012 06:11:07 -0800 Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-02.mgc.mentorg.com (147.34.96.168) with Microsoft SMTP Server id 14.1.289.1; Fri, 30 Nov 2012 06:11:06 -0800 Message-ID: <50B8BE62.3040602@codesourcery.com> Date: Fri, 30 Nov 2012 14:11:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:15.0) Gecko/20120911 Thunderbird/15.0.1 MIME-Version: 1.0 To: Mark Kettenis CC: Subject: Re: [committed] Remove a redundant condition check in tic6x-linux-tdep.c References: <1354260922-13995-1-git-send-email-yao@codesourcery.com> <201211301222.qAUCMSLI011405@glazunov.sibelius.xs4all.nl> In-Reply-To: <201211301222.qAUCMSLI011405@glazunov.sibelius.xs4all.nl> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-11/txt/msg00924.txt.bz2 On 11/30/2012 08:22 PM, Mark Kettenis wrote: > Hmm, well, perhaps the regnum variable should just be made signed. > That's typically what we use for register numbers, since -1 has the > special meaning of "all registers"/ Mark, This patch is to change function tic6x_register_sigcontext_offset, which is to get the input REGNUM, and return the offset of corresponding register in 'struct sigcontext'. So -1 means 'all registers' doesn't apply here. Thank for reminding me this, I don't know -1 means 'all registers' before. -- Yao (齐尧)