Re: [PATCH 2/2] new tracepoint downloaded MI notification.

dje
2012-10-15T18:03:28Z

Yao Qi writes:
> Hi,
> This patch is to add a new MI notification to MI front-end when
> tracepoints are downloaded to target.
>
> gdb:
>
> 2012-09-27 Yao Qi <yao@codesourcery.com>
>
> * target.c: Include "observer.h".
> (target_download_tracepoint): New.
> * target.h (target_download_tracepoint): Remoe macro.
> Declare target_download_tracepoint.
> * mi/mi-interp.c (mi_interpreter_init):
> (mi_tracepoint_downloaded): New.
> * observer.sh (struct bp_location): Forward declaration.
>
> * NEWS: Mention it.
>
> gdb/doc:
>
> 2012-09-27 Yao Qi <yao@codesourcery.com>
>
> * observer.texi (GDB Observers): New observer
> 'tracepoint-downloaded'.
> * gdb.texinfo (GDB/MI Async Records): Document for MI notification
> "=tracepoint-downloaded".
>
> gdb/testsuite:
>
> 2012-09-27 Yao Qi <yao@codesourcery.com>
>
> * gdb.trace/mi-traceframe-changed.exp (test_tfind_remote): Adjust.
> * gdb.trace/mi-tracepoint-downloaded.exp: New.

Hi.
It would be useful if the reason why this notification exists was specified in the code.
E.g, "This notification exists because frontends ... [fill in the blank]."