From: Pedro Alves <palves@redhat.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: RFC: make thread_list static
Date: Wed, 28 Nov 2012 09:27:00 -0000 [thread overview]
Message-ID: <50B5D8EF.1020400@redhat.com> (raw)
In-Reply-To: <87y5hmdhl0.fsf@fleche.redhat.com>
On 11/27/2012 06:30 PM, Tom Tromey wrote:
> I've had this patch on a branch for a while and thought I would send it
> today.
>
> I noticed that thread_list is only used in one place outside of
> thread.c. It seems generally preferable to me to keep things like this
> private. So, this patch makes it static and updates the one user.
Well, if you ask me, I can't agree since I had added it recently (git blame
points at last July). :-)
This was after getting sick of writing callback-style iterators in the itsets
run-control work, and introducing the macro there first. This isn't different
from ALL_OBJFILES and several other similar macros in the tree (which I realize
from this that you'd rather remove). We could switch to callback-style before pushing
those patches in, but, IMO, the convenience and readability of the resulting code
trumps the implementation detail exposure detail.
--
Pedro Alves
next prev parent reply other threads:[~2012-11-28 9:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-27 18:30 Tom Tromey
2012-11-28 7:27 ` Joel Brobecker
2012-11-28 8:41 ` Yao Qi
2012-11-28 9:27 ` Pedro Alves [this message]
2012-11-28 14:35 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50B5D8EF.1020400@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox