From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1626 invoked by alias); 28 Nov 2012 08:41:26 -0000 Received: (qmail 1603 invoked by uid 22791); 28 Nov 2012 08:41:25 -0000 X-SWARE-Spam-Status: No, hits=-4.5 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 28 Nov 2012 08:41:20 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1TddCp-0004GG-HN from Yao_Qi@mentor.com ; Wed, 28 Nov 2012 00:41:19 -0800 Received: from SVR-ORW-FEM-05.mgc.mentorg.com ([147.34.97.43]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Wed, 28 Nov 2012 00:41:18 -0800 Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-05.mgc.mentorg.com (147.34.97.43) with Microsoft SMTP Server id 14.1.289.1; Wed, 28 Nov 2012 00:41:18 -0800 Message-ID: <50B5CE10.9060208@codesourcery.com> Date: Wed, 28 Nov 2012 08:41:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:15.0) Gecko/20120911 Thunderbird/15.0.1 MIME-Version: 1.0 To: Tom Tromey CC: Subject: Re: RFC: make thread_list static References: <87y5hmdhl0.fsf@fleche.redhat.com> In-Reply-To: <87y5hmdhl0.fsf@fleche.redhat.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-11/txt/msg00798.txt.bz2 On 11/28/2012 02:30 AM, Tom Tromey wrote: > -/* Traverse all threads. */ > - > -#define ALL_THREADS(T) \ > - for (T = thread_list; T; T = T->next) > - We had ITSET patches which use this macro heavily. However they don't go in, I am not sure it is a good evidence of the usefulness of this macro. Of course, the same can be achieved by iterator functions. -- Yao (齐尧)