From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14881 invoked by alias); 28 Nov 2012 04:56:36 -0000 Received: (qmail 14873 invoked by uid 22791); 28 Nov 2012 04:56:34 -0000 X-SWARE-Spam-Status: No, hits=-4.3 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 28 Nov 2012 04:56:27 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1TdZhC-0004Ps-B6 from Hui_Zhu@mentor.com ; Tue, 27 Nov 2012 20:56:26 -0800 Received: from SVR-ORW-FEM-03.mgc.mentorg.com ([147.34.97.39]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Tue, 27 Nov 2012 20:56:26 -0800 Received: from [127.0.0.1] (147.34.91.1) by svr-orw-fem-03.mgc.mentorg.com (147.34.97.39) with Microsoft SMTP Server id 14.1.289.1; Tue, 27 Nov 2012 20:56:24 -0800 Message-ID: <50B59974.3070305@mentor.com> Date: Wed, 28 Nov 2012 04:56:00 -0000 From: Hui Zhu User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: Yao Qi CC: Hui Zhu , Eli Zaretskii , Subject: Re: [PATCH] Add CTF support to GDB [4/4] doc References: <50AC324D.7010703@mentor.com> <83r4nmvowo.fsf@gnu.org> <50AEDF18.6090707@mentor.com> <83sj80u5rs.fsf@gnu.org> <83vccqx6hf.fsf@gnu.org> <50B57A77.8090006@codesourcery.com> In-Reply-To: <50B57A77.8090006@codesourcery.com> Content-Type: multipart/mixed; boundary="------------060307080408060805070802" X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-11/txt/msg00792.txt.bz2 --------------060307080408060805070802 Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit Content-length: 1163 On 11/28/12 10:44, Yao Qi wrote: > On 11/28/2012 09:40 AM, Hui Zhu wrote: >> --- a/doc/gdb.texinfo >> +++ b/doc/gdb.texinfo >> @@ -12069,7 +12069,7 @@ of trace data, via the @code{target tfil >> @table @code >> >> @kindex tsave >> -@item tsave [ -r ] @var{filename} >> +@item tsave [ -r ] [-ctf] @var{filename} > > According patch 1/4 (function ctf_save), 'tsave -ctf foo' will save ctf files into directory 'foo'. If so, we have to reflect this in document. > > Can we do 'tsave -r -ctf foo'? IIRC, it is not allowed. > > It can be written something like this, > > @item tsave [ -r ] @var{filename} > @itemx tsave [-ctf] @var{dirname} > >> @@ -12089,6 +12095,11 @@ the state of the trace run at the moment >> as the current trace frame you are examining. @var{filename} must be >> on a filesystem accessible to the host. >> >> +@kindex target ctf >> +@kindex ctf >> +@item target ctf @var{filename} >> +Use the file named @var{filename} as a source of CTF trace data. >> + > > According to patch 3/4 (function init_ctf_ops), 'target ctf foo' uses directory foo instead of file foo. > Post a new version according to your comments. Thanks, Hui --------------060307080408060805070802 Content-Type: text/plain; charset="us-ascii"; name="ctf-doc.txt" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="ctf-doc.txt" Content-length: 1973 LS0tIGEvZG9jL2dkYi50ZXhpbmZvCisrKyBiL2RvYy9nZGIudGV4aW5mbwpA QCAtMTIwNzAsNiArMTIwNzAsNyBAQCBvZiB0cmFjZSBkYXRhLCB2aWEgdGhl IEBjb2Rle3RhcmdldCB0ZmlsCiAKIEBraW5kZXggdHNhdmUKIEBpdGVtIHRz YXZlIFsgLXIgXSBAdmFye2ZpbGVuYW1lfQorQGl0ZW14IHRzYXZlIFstY3Rm XSBAdmFye2Rpcm5hbWV9CiBTYXZlIHRoZSB0cmFjZSBkYXRhIHRvIEB2YXJ7 ZmlsZW5hbWV9LiAgQnkgZGVmYXVsdCwgdGhpcyBjb21tYW5kCiBhc3N1bWVz IHRoYXQgQHZhcntmaWxlbmFtZX0gcmVmZXJzIHRvIHRoZSBob3N0IGZpbGVz eXN0ZW0sIHNvIGlmCiBuZWNlc3NhcnkgQHZhbHVle0dEQk59IHdpbGwgY29w eSByYXcgdHJhY2UgZGF0YSB1cCBmcm9tIHRoZSB0YXJnZXQgYW5kCkBAIC0x MjA3OCw2ICsxMjA3OSwxMiBAQCBvcHRpb25hbCBhcmd1bWVudCBAY29kZXst cn0gKGBgcmVtb3RlJycpCiB0aGUgZGF0YSBkaXJlY3RseSBpbnRvIEB2YXJ7 ZmlsZW5hbWV9IGluIGl0cyBvd24gZmlsZXN5c3RlbSwgd2hpY2ggbWF5IGJl CiBtb3JlIGVmZmljaWVudCBpZiB0aGUgdHJhY2UgYnVmZmVyIGlzIHZlcnkg bGFyZ2UuICAoTm90ZSwgaG93ZXZlciwgdGhhdAogQGNvZGV7dGFyZ2V0IHRm aWxlfSBjYW4gb25seSByZWFkIGZyb20gZmlsZXMgYWNjZXNzaWJsZSB0byB0 aGUgaG9zdC4pCitCeSBkZWZhdWx0LCB0aGlzIGNvbW1hbmQgd2lsbCBzYXZl IHRyYWNlIGZyYW1lIGludG8gdGZpbGUgZm9ybWF0LgorWW91IGNhbiBzdXBw bHkgdGhlIG9wdGlvbmFsIGFyZ3VtZW50IEBjb2Rley1jdGZ9IHRvIHNhdmUg ZGF0ZSBpbiBDVEYKK2Zvcm1hdC4gIFRoZSBAZGZue0NvbW1vbiBUcmFjZSBG b3JtYXR9IChDVEYpIGlzIHByb3Bvc2VkIGFzIGEgdHJhY2UgZm9ybWF0Cit0 aGF0IHN1aXRzIHRoZSBuZWVkcyBvZiB0aGUgZW1iZWRkZWQsIHRlbGVjb20s IGhpZ2gtcGVyZm9ybWFuY2UKK2FuZCBrZXJuZWwgY29tbXVuaXRpZXMuICBQ bGVhc2UgZ290byBAaW5kaWNhdGV1cmx7aHR0cDovL3d3dy5lZmZpY2lvcy5j b20vY3RmfQordG8gZ2V0IG1vcmUgaW5mb3JtYXRpb24uCiAKIEBraW5kZXgg dGFyZ2V0IHRmaWxlCiBAa2luZGV4IHRmaWxlCkBAIC0xMjA4OSw2ICsxMjA5 NiwxMSBAQCB0aGUgc3RhdGUgb2YgdGhlIHRyYWNlIHJ1biBhdCB0aGUgbW9t ZW50CiBhcyB0aGUgY3VycmVudCB0cmFjZSBmcmFtZSB5b3UgYXJlIGV4YW1p bmluZy4gIEB2YXJ7ZmlsZW5hbWV9IG11c3QgYmUKIG9uIGEgZmlsZXN5c3Rl bSBhY2Nlc3NpYmxlIHRvIHRoZSBob3N0LgogCitAa2luZGV4IHRhcmdldCBj dGYKK0BraW5kZXggY3RmCitAaXRlbSB0YXJnZXQgY3RmIEB2YXJ7ZGlybmFt ZX0KK1VzZSB0aGUgZGlyZWN0b3J5IG5hbWVkIEB2YXJ7ZGlybmFtZX0gYXMg YSBzb3VyY2Ugb2YgQ1RGIHRyYWNlIGRhdGEuCisKIEBlbmQgdGFibGUKIAog QG5vZGUgT3ZlcmxheXMK --------------060307080408060805070802--