Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: lgustavo@codesourcery.com
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Support targets that know how to step over breakpoints
Date: Tue, 27 Nov 2012 17:04:00 -0000	[thread overview]
Message-ID: <50B4E83D.9010507@redhat.com> (raw)
In-Reply-To: <50B4DA35.3010206@codesourcery.com>

On 11/27/2012 03:20 PM, Luis Machado wrote:

> Meanwhile i've updated this patch for the latest cvs head.
> 
> I'm wondering if the patch is too ugly for someone to take a look at it or if it is too odd a feature to add. I suppose not.
> 
> Hopefully i can get some traction with this new refreshed and shiny version! :-)

I was hoping others could comment.  :-)

Last we discussed this (probably a years ago already), I expressed my
concern with upstreaming this as is.  It's that this works by sending a regular
step command to the target, and then the target steps over any breakpoint that
may be at the current PC.  If GDB is wanting to move past a breakpoint, this still
needs to do:

 -> vCont;s
 <- T05  (step finished)
 <- vCont;c

An alternative would be to get rid of that T05, by defining new commands that
tell the target to step-over-breakpoint, or continue-over-breakpoint (and signal
variants).  E.g., sbc to mean step-break-continue:

 -> vCont;spc

That'd move past the breakpoint without causing a stop immediately.

Guess I need to convince myself the current design is good enough.  Comments?

-- 
Pedro Alves


  reply	other threads:[~2012-11-27 17:04 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-04 12:48 Luis Machado
2012-10-17 11:43 ` Luis Machado
2012-10-30 10:58   ` Luis Machado
2012-11-27 15:20     ` Luis Machado
2012-11-27 17:04       ` Pedro Alves [this message]
2012-11-29 14:21         ` Luis Machado
2012-11-30 18:50           ` Pedro Alves
2012-11-30 18:53             ` Pedro Alves
2013-02-28  7:16               ` Hui Zhu
2013-05-07  2:50                 ` Hui Zhu
2012-10-30 11:53 ` Yao Qi
2012-10-30 12:01   ` Luis Machado

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50B4E83D.9010507@redhat.com \
    --to=palves@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=lgustavo@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox