From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19389 invoked by alias); 27 Nov 2012 08:12:18 -0000 Received: (qmail 19374 invoked by uid 22791); 27 Nov 2012 08:12:16 -0000 X-SWARE-Spam-Status: No, hits=-4.5 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 27 Nov 2012 08:12:03 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1TdGGw-0002aJ-Kf from Yao_Qi@mentor.com ; Tue, 27 Nov 2012 00:12:02 -0800 Received: from SVR-ORW-FEM-03.mgc.mentorg.com ([147.34.97.39]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Tue, 27 Nov 2012 00:12:02 -0800 Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-03.mgc.mentorg.com (147.34.97.39) with Microsoft SMTP Server id 14.1.289.1; Tue, 27 Nov 2012 00:12:01 -0800 Message-ID: <50B475B3.9080700@codesourcery.com> Date: Tue, 27 Nov 2012 08:12:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:15.0) Gecko/20120911 Thunderbird/15.0.1 MIME-Version: 1.0 To: Pedro Alves CC: Subject: Re: [PATCH] use gdbarch_addr_bits_remove for entry point address References: <1353404184-22073-1-git-send-email-yao@codesourcery.com> <50AFD573.1090601@gmail.com> <50B0ABF9.1080606@codesourcery.com> <50B3591D.7070401@redhat.com> In-Reply-To: <50B3591D.7070401@redhat.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-11/txt/msg00700.txt.bz2 On 11/26/2012 07:57 PM, Pedro Alves wrote: > Please be more specific: > > * objfiles.c (entry_point_address_query): Call > gdbarch_convert_from_func_ptr_addr and gdbarch_addr_bits_remove > here ... > (init_entry_point_info): ... instead of here. > > That's more useful for archaeology. > >> > * solib-svr4.c (exec_entry_point): Likewise. > "Likewise" here doesn't make sense. Perhaps: > > * solib-svr4.c (exec_entry_point): Call gdbarch_addr_bits_remove. > The changelog entry is updated, and patch is committed. Thanks for the review. -- Yao (齐尧)