From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-96210-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 13778 invoked by alias); 26 Nov 2012 11:41:44 -0000
Received: (qmail 13769 invoked by uid 22791); 26 Nov 2012 11:41:44 -0000
X-SWARE-Spam-Status: No, hits=-7.9 required=5.0	tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 26 Nov 2012 11:41:36 +0000
Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qAQBfXK0008605	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Mon, 26 Nov 2012 06:41:34 -0500
Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11])	by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id qAQBfWbg017695;	Mon, 26 Nov 2012 06:41:33 -0500
Message-ID: <50B3556C.1030704@redhat.com>
Date: Mon, 26 Nov 2012 11:41:00 -0000
From: Pedro Alves <palves@redhat.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0
MIME-Version: 1.0
To: Yao Qi <yao@codesourcery.com>
CC: gdb-patches@sourceware.org
Subject: Re: [PATCH] Turn -Wempty-body on in gdbserver?
References: <1353927773-24944-1-git-send-email-yao@codesourcery.com>
In-Reply-To: <1353927773-24944-1-git-send-email-yao@codesourcery.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-11/txt/msg00648.txt.bz2

On 11/26/2012 11:02 AM, Yao Qi wrote:
> Hello,
> When compile gdbserver with clang, I get the following warning,
> 
>  gdb/gdbserver/linux-low.c:662:28: error: if statement has empty body [-Werror,-Wempty-body]
>             /* Errors ignored.  */;
>                                   ^
> and this reminds me that we turned '-Wempty-body' on in gdb by this
> patch <http://sourceware.org/ml/gdb-patches/2012-10/msg00349.html>.
> It is also justified to do the same in gdbserver.
> 
> Rebuild gdbserver for i686-pc-linux-gnu, arm-linux-gnueabi,
> tic6x-uclinux, misp-linux-gnu and mingw32.  Is it OK?

OK.  Thanks.

-- 
Pedro Alves