From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5280 invoked by alias); 16 Jun 2005 20:15:12 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 5183 invoked by uid 22791); 16 Jun 2005 20:15:01 -0000 Received: from mail-out3.apple.com (HELO mail-out3.apple.com) (17.254.13.22) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Thu, 16 Jun 2005 20:15:01 +0000 Received: from mailgate2.apple.com (a17-128-100-204.apple.com [17.128.100.204]) by mail-out3.apple.com (8.12.11/8.12.11) with ESMTP id j5GKF0gq007679 for ; Thu, 16 Jun 2005 13:15:00 -0700 (PDT) Received: from relay3.apple.com (relay3.apple.com) by mailgate2.apple.com (Content Technologies SMTPRS 4.3.17) with ESMTP id ; Thu, 16 Jun 2005 13:14:59 -0700 Received: from [17.201.22.21] (moleja.apple.com [17.201.22.21]) by relay3.apple.com (8.12.11/8.12.11) with ESMTP id j5GKExnY029654; Thu, 16 Jun 2005 13:14:59 -0700 (PDT) In-Reply-To: <17072.62436.183299.55978@farnswood.snap.net.nz> References: <17072.62436.183299.55978@farnswood.snap.net.nz> Mime-Version: 1.0 (Apple Message framework v728) Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Message-Id: <50B12BF2-9C7D-43ED-AF21-D1EA42AC7115@apple.com> Cc: gdb-patches@sources.redhat.com Content-Transfer-Encoding: 7bit From: Jason Molenda Subject: Re: [PATCH] -stack-select-frame Date: Thu, 16 Jun 2005 20:15:00 -0000 To: Nick Roberts X-SW-Source: 2005-06/txt/msg00224.txt.bz2 Hi Nick, You wrote: > I'm not aware of anyone using this command - I don't see how they > currently > could really. I think its less likely to break existing behaviour > than this > change: Xcode uses stack-select-frame -- I'm not sure how a real GUI could avoid using stack-select-frame. On Jun 15, 2005, at 8:37 PM, Nick Roberts wrote: > Here, hopefully, is a much more sensible one. The idea is the > same: that > -stack-select-frame tells the frontend what the current or selected > frame > is. I don't care, really, but isn't necessary in our experience at Apple. The first thing a GUI has to do when execution has stopped is get the current stack. It shows the stack to the developer, and then the developer decides that stack frame 2 is of interest to her, so she clicks there and the GUI sends stack-select-frame. The GUI already has the stack-list-frames output from when it stopped -- it knows very well what's at frame 2. If the GUI has short term memory problems, stack-list-frames is always at its disposal. > * mi/mi-cmd-stack.c (mi_cmd_stack_select_frame): Don't test for > stack. Print frame details. > enum mi_cmd_result > mi_cmd_stack_select_frame (char *command, char **argv, int argc) > { > - if (!target_has_stack) > - error (_("mi_cmd_stack_select_frame: No stack.")); > - Why are you suggesting this change? If the GUI is requesting a stack when the inferior isn't running, that's an error. Jason