From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18405 invoked by alias); 23 Nov 2012 17:07:59 -0000 Received: (qmail 18389 invoked by uid 22791); 23 Nov 2012 17:07:57 -0000 X-SWARE-Spam-Status: No, hits=-8.3 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,MAY_BE_FORGED,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from e24smtp03.br.ibm.com (HELO e24smtp03.br.ibm.com) (32.104.18.24) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 23 Nov 2012 17:07:52 +0000 Received: from /spool/local by e24smtp03.br.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 23 Nov 2012 15:07:49 -0200 Received: from d24dlp01.br.ibm.com (9.18.248.204) by e24smtp03.br.ibm.com (10.172.0.139) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Fri, 23 Nov 2012 15:07:47 -0200 Received: from d24relay02.br.ibm.com (d24relay02.br.ibm.com [9.13.184.26]) by d24dlp01.br.ibm.com (Postfix) with ESMTP id 2E53B352004B; Fri, 23 Nov 2012 12:07:47 -0500 (EST) Received: from d24av04.br.ibm.com (d24av04.br.ibm.com [9.8.31.97]) by d24relay02.br.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id qANH7ZfO23789598; Fri, 23 Nov 2012 15:07:36 -0200 Received: from d24av04.br.ibm.com (loopback [127.0.0.1]) by d24av04.br.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id qANF7ZXh018449; Fri, 23 Nov 2012 13:07:36 -0200 Received: from [9.18.235.230] (grandaddy.br.ibm.com [9.18.235.230] (may be forged)) by d24av04.br.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id qANF7ZSH018444; Fri, 23 Nov 2012 13:07:35 -0200 Message-ID: <50AFAD62.8040308@linux.vnet.ibm.com> Date: Fri, 23 Nov 2012 17:07:00 -0000 From: Edjunior Barbosa Machado User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: Alan Modra CC: gdb-patches@sourceware.org, binutils@sourceware.org Subject: Re: [PATCH] Fix gdb disassemble for power6/power7 instructions References: <1352785540-22911-1-git-send-email-emachado@linux.vnet.ibm.com> <20121113234638.GI3056@bubble.grove.modra.org> <20121123032853.GW3056@bubble.grove.modra.org> In-Reply-To: <20121123032853.GW3056@bubble.grove.modra.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Content-Scanned: Fidelis XPS MAILER x-cbid: 12112317-9254-0000-0000-00000AE02F63 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-11/txt/msg00624.txt.bz2 On 11/23/2012 01:28 AM, Alan Modra wrote: > One of the effects of updating to a power7 default is that conditional > branch hints are displayed for "at" style hints rather than the older > "y" hints. When using "y" hints the disassembler always showed the > hint, eg. "bne-" or "bne+". Now you'll see "bne" most times. This > meant updating the testsuite. I made one gas test disassemble for > plain ppc just to ensure the older "y" hints continue to be available. > > Committed. Thanks a lot for the patch, Alan. This also fixes the issues with gdb disassemble for power6 and power7 instructions. With these changes on powerpc_init_dialect(), I'd suggest to remove the info->mach checking from gdb. Ok? -- Edjunior 2012-11-23 Edjunior Machado * rs6000-tdep.c (gdb_print_insn_powerpc): Remove info->mach checking, since now it is being done in binutils' powerpc_init_dialect(). --- gdb/rs6000-tdep.c | 15 --------------- 1 files changed, 0 insertions(+), 15 deletions(-) diff --git a/gdb/rs6000-tdep.c b/gdb/rs6000-tdep.c index 1797cc5..07b81bc 100644 --- a/gdb/rs6000-tdep.c +++ b/gdb/rs6000-tdep.c @@ -3084,21 +3084,6 @@ find_variant_by_arch (enum bfd_architecture arch, unsigned long mach) static int gdb_print_insn_powerpc (bfd_vma memaddr, disassemble_info *info) { - if (!info->disassembler_options) - { - /* When debugging E500 binaries and disassembling code containing - E500-specific (SPE) instructions, one sometimes sees AltiVec - instructions instead. The opcode spaces for SPE instructions - and AltiVec instructions overlap, and specifiying the "any" cpu - looks for AltiVec instructions first. If we know we're - debugging an E500 binary, however, we can specify the "e500x2" - cpu and get much more sane disassembly output. */ - if (info->mach == bfd_mach_ppc_e500) - info->disassembler_options = "e500x2"; - else - info->disassembler_options = "any"; - } - if (info->endian == BFD_ENDIAN_BIG) return print_insn_big_powerpc (memaddr, info); else -- 1.7.1