Re: [PATCH 2/2] new tracepoint downloaded MI notification.

Pedro Alves
2012-09-28T17:44:25Z

On 09/28/2012 01:49 AM, Yao Qi wrote:
> +@item =tracepoint-downloaded,id="@var{number}",address="@var{addr}"
> +Reports that a tracepoint was downloaded to target. The @var{number}
> +is the ordinal number of the tracepoint. The @var{addr} is the
> +address where tracepoint was downloaded.

The "address where tracepoint was downloaded" makes me think this
returns the address in gdbserver's memory that holds the tracepoint
object. But it's not, it's the tracepoint's address, as in the
address the tracepoint is set at in the inferior.

Took me a second to recall, but the reason the address is
necessary is multi-location tracepoints -- a tracepoint on the
target is identified by the { number, address } tuple. We don't
send over the location's sub number (like 1.1, 1.2, etc.).

Should we mention this somewhere (other than at the tracepoint
packets description), so frontend people don't wonder whether they
can ignore the address field, and why aren't the other fields of
the tracepoint (like spec string) included?

--
Pedro Alves