From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24144 invoked by alias); 22 Nov 2012 08:07:56 -0000 Received: (qmail 24133 invoked by uid 22791); 22 Nov 2012 08:07:55 -0000 X-SWARE-Spam-Status: No, hits=-4.5 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 22 Nov 2012 08:07:50 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1TbRp7-0000w7-Mp from Yao_Qi@mentor.com for gdb-patches@sourceware.org; Thu, 22 Nov 2012 00:07:49 -0800 Received: from SVR-ORW-FEM-02.mgc.mentorg.com ([147.34.96.206]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Thu, 22 Nov 2012 00:07:49 -0800 Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-02.mgc.mentorg.com (147.34.96.168) with Microsoft SMTP Server id 14.1.289.1; Thu, 22 Nov 2012 00:07:48 -0800 Message-ID: <50ADDD4D.8090709@codesourcery.com> Date: Thu, 22 Nov 2012 08:07:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:15.0) Gecko/20120911 Thunderbird/15.0.1 MIME-Version: 1.0 To: Subject: Re: [PATCH 4/4] Handle TYPE_CODE_MEMBERPTR References: <1353569539-744-1-git-send-email-yao@codesourcery.com> <1353569539-744-5-git-send-email-yao@codesourcery.com> In-Reply-To: <1353569539-744-5-git-send-email-yao@codesourcery.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-11/txt/msg00597.txt.bz2 On 11/22/2012 03:32 PM, Yao Qi wrote: > + arg2 = value_cast (lookup_pointer_type (TYPE_DOMAIN_TYPE (type)), > + arg2); > + > + mem_offset = value_as_long (arg1); > + > + arg1 = value_from_pointer (lookup_pointer_type (TYPE_TARGET_TYPE (type)), These two lines are too long. Fixed in the updated patch. -- Yao (齐尧) gdb: 2012-11-22 Daniel Jacobowitz * eval.c (evaluate_subexp_standard): Handle TYPE_CODE_MEMBERPTR. --- gdb/eval.c | 15 +++++++++++++++ 1 files changed, 15 insertions(+), 0 deletions(-) diff --git a/gdb/eval.c b/gdb/eval.c index 82ea81b..55582e0 100644 --- a/gdb/eval.c +++ b/gdb/eval.c @@ -1400,6 +1400,21 @@ evaluate_subexp_standard (struct type *expect_type, tem = 2; argvec[1] = arg2; } + else if (TYPE_CODE (type) == TYPE_CODE_MEMBERPTR) + { + struct type *type_ptr + = lookup_pointer_type (TYPE_DOMAIN_TYPE (type)); + + /* Now, convert these values to an address. */ + arg2 = value_cast (type_ptr, arg2); + + mem_offset = value_as_long (arg1); + + arg1 = value_from_pointer (type_ptr, + value_as_long (arg2) + mem_offset); + arg1 = value_ind (arg1); + tem = 1; + } else error (_("Non-pointer-to-member value used in pointer-to-member " "construct")); -- 1.7.7.6