From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8111 invoked by alias); 21 Nov 2012 13:11:15 -0000 Received: (qmail 8007 invoked by uid 22791); 21 Nov 2012 13:11:13 -0000 X-SWARE-Spam-Status: No, hits=-7.8 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 21 Nov 2012 13:11:02 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qALDAvqP006551 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 21 Nov 2012 08:10:57 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id qALDAtp5028196; Wed, 21 Nov 2012 08:10:56 -0500 Message-ID: <50ACD2DF.6000503@redhat.com> Date: Wed, 21 Nov 2012 13:11:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121029 Thunderbird/16.0.2 MIME-Version: 1.0 To: kv.bhat@samsung.com CC: "gdb-patches@sourceware.org" Subject: Re: [PATCH] Fix for incorect breakpoint set in case of clang compiled binary References: <12011231.483671353387478250.JavaMail.weblogic@epml02> In-Reply-To: <12011231.483671353387478250.JavaMail.weblogic@epml02> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-11/txt/msg00565.txt.bz2 I updated my checkout this morning and stumbled on: ../../src/gdb/i386-tdep.c: In function ‘i386_skip_prologue’: ../../src/gdb/i386-tdep.c:1586:3: error: ISO C90 forbids mixed declarations and code [-Werror=declaration-after-statement] cc1: all warnings being treated as errors I also noticed the indentation of the if block is not according to the convention. I can't find an email approving the change. Was there some private discussion perhaps? -- Pedro Alves