From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22313 invoked by alias); 19 Nov 2012 15:09:12 -0000 Received: (qmail 22260 invoked by uid 22791); 19 Nov 2012 15:09:11 -0000 X-SWARE-Spam-Status: No, hits=-7.9 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 19 Nov 2012 15:08:36 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qAJF8YMY011683 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 19 Nov 2012 10:08:34 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id qAJF8UId015630; Mon, 19 Nov 2012 10:08:32 -0500 Message-ID: <50AA4B6E.1030600@redhat.com> Date: Mon, 19 Nov 2012 15:09:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121029 Thunderbird/16.0.2 MIME-Version: 1.0 To: Joel Brobecker CC: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [10/10] RFC: remove gdb_wait.h References: <87obiyzns7.fsf@fleche.redhat.com> <87wqxmwthq.fsf@fleche.redhat.com> <50A67797.7050005@redhat.com> <20121117023010.GA9964@adacore.com> In-Reply-To: <20121117023010.GA9964@adacore.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-11/txt/msg00501.txt.bz2 On 11/17/2012 02:30 AM, Joel Brobecker wrote: >> #ifndef __WCLONE >> #define __WCLONE 0x80000000 /* Wait for cloned process. */ >> #endif >> >> I'm not sure whether we still encounter systems without these, and >> if gdb works on them at all. Waiting for build failure reports would >> be an option. >> >> We could move them to say, common/linux-ptrace.h. __WALL is already there. > > I normally suggest that we wait for build failure reports, but your > suggestion seems so simple that I'd just play it safe, and add it > there. Given the flag value, I'd even venture that if __WALL is > defined, I'm guessing __WCLONE should be too? I don't know whether they were added at the same time or not. Probably were, yes. -- Pedro Alves