From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29671 invoked by alias); 16 Nov 2012 17:28:06 -0000 Received: (qmail 29663 invoked by uid 22791); 16 Nov 2012 17:28:05 -0000 X-SWARE-Spam-Status: No, hits=-7.7 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 16 Nov 2012 17:27:54 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qAGHRr6M003332 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 16 Nov 2012 12:27:53 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id qAGHRqp2022354; Fri, 16 Nov 2012 12:27:52 -0500 Message-ID: <50A67797.7050005@redhat.com> Date: Fri, 16 Nov 2012 17:28:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121029 Thunderbird/16.0.2 MIME-Version: 1.0 To: Tom Tromey CC: gdb-patches@sourceware.org Subject: Re: [10/10] RFC: remove gdb_wait.h References: <87obiyzns7.fsf@fleche.redhat.com> <87wqxmwthq.fsf@fleche.redhat.com> In-Reply-To: <87wqxmwthq.fsf@fleche.redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-11/txt/msg00464.txt.bz2 Assuming sys/wait.h doesn't get replaced on older GNU/Linux systems, this loses these bits: /* For native GNU/Linux we may use waitpid and the __WCLONE option. It is of course dangerous not to use the REAL header file... . */ /* Bits in the third argument to `waitpid'. */ #ifndef WNOHANG #define WNOHANG 1 /* Don't block waiting. */ #endif #ifndef WUNTRACED #define WUNTRACED 2 /* Report status of stopped children. */ #endif #ifndef __WCLONE #define __WCLONE 0x80000000 /* Wait for cloned process. */ #endif I'm not sure whether we still encounter systems without these, and if gdb works on them at all. Waiting for build failure reports would be an option. We could move them to say, common/linux-ptrace.h. __WALL is already there. -- Pedro Alves